Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-114626: add PyCFunctionFast and PyCFunctionFastWithKeywords#114627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 6 commits intopython:mainfromdavidhewitt:gh-114626
Feb 15, 2024

Conversation

@davidhewitt
Copy link
Contributor

@davidhewittdavidhewitt commentedJan 26, 2024•
edited by github-actionsbot
Loading

Closes#114626

I basically did a find-and-replace, plus added typedefs to keep_PyCFunctionFast and_PyCFunctionFastWithKeywords around for backwards compatibility.

📚 Documentation preview 📚:https://cpython-previews--114627.org.readthedocs.build/

@ghost
Copy link

ghost commentedJan 26, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@encukouencukou left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense to me.
The type names aren't really needed in C code -- you typically just define a function with the given signature -- so they were left out.

The names should be added toMisc/stable_abi.toml (see[typedef.PyCFunction] there.)

This is a limited API; let's play by the book (well, the book we want to write) and let the C-API WG know. (edit: opened issue atcapi-workgroup/decisions#11 )

@davidhewitt
Copy link
ContributorAuthor

@encukou thanks for tidying this up, sorry it was just off the top of my to-do list and I hadn't quite got around to it yet 😞

encukou reacted with thumbs up emoji

@encukou
Copy link
Member

No problem! Thanks for bringing it up and starting.
I started with GitHub suggestions, but then they piled up and I wanted to test them, so I ended up with commits to push :)

davidhewitt reacted with thumbs up emoji

@encukouencukou merged commit9e3729b intopython:mainFeb 15, 2024
vstinner added a commit to vstinner/cython that referenced this pull requestFeb 16, 2024
Python 3.13a4 adds a public PyCFunctionFastWithKeywords type.*python/cpython@9e3729b*python/cpython#114627*capi-workgroup/decisions#11Python 3.13a1 removed the private _PyCFunctionFastWithKeywords type.
vstinner added a commit to vstinner/cython that referenced this pull requestFeb 16, 2024
Python 3.13a4 adds a public PyCFunctionFastWithKeywords type andremoves the private _PyCFunctionFastWithKeywords type:*python/cpython@9e3729b*python/cpython#114627*capi-workgroup/decisions#11
@vstinner
Copy link
Member

FYI PR to update Cython:cython/cython#6003

vstinner added a commit to vstinner/cython that referenced this pull requestFeb 16, 2024
Python 3.13a4 adds a public PyCFunctionFastWithKeywords andPyCFunctionFast types and removes the private_PyCFunctionFastWithKeywords and _PyCFunctionFast types:*python/cpython@9e3729b*python/cpython#114627*capi-workgroup/decisions#11
scoder pushed a commit to cython/cython that referenced this pull requestFeb 16, 2024
…3a4 (GH-6003)Python 3.13a4 adds a public PyCFunctionFastWithKeywords andPyCFunctionFast types and removes the private_PyCFunctionFastWithKeywords and _PyCFunctionFast types:*python/cpython@9e3729b*python/cpython#114627*capi-workgroup/decisions#11
@vstinner
Copy link
Member

typedef PyCFunctionWithKeywords _PyCFunctionWithKeywords;

Wait, the old name is_PyCFunctionFastWithKeywords, not_PyCFunctionWithKeywords:Fast is missing...

@vstinner
Copy link
Member

I wrotecython/cython@e9b08d3 to make Cython compatibility with Python 3.13 alpha4.

@vstinner
Copy link
Member

Wait, the old name is _PyCFunctionFastWithKeywords, not _PyCFunctionWithKeywords: Fast is missing...

I wrote PR#115561 to fix this typo.

scoder pushed a commit to cython/cython that referenced this pull requestFeb 18, 2024
…3a4 (GH-6003)Python 3.13a4 adds a public PyCFunctionFastWithKeywords andPyCFunctionFast types and removes the private_PyCFunctionFastWithKeywords and _PyCFunctionFast types:*python/cpython@9e3729b*python/cpython#114627*capi-workgroup/decisions#11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@aiskaiskaisk left review comments

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose unprefixed variants of_PyCFunctionFast and_PyCFunctionFastWithKeywords

4 participants

@davidhewitt@encukou@vstinner@aisk
[8]ページ先頭
©2009-2025 Movatter.jp