Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixc-api/file.rst indexes#114608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 2 commits intopython:mainfromsobolevn:issue-114546
Jan 27, 2024
Merged

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedJan 26, 2024•
edited by github-actionsbot
Loading

It is now:
Снимок экрана 2024-01-26 в 18 48 18

Fixes#114546

📚 Documentation preview 📚:https://cpython-previews--114608.org.readthedocs.build/

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can also use.. c:namespace:: NULL.

@sobolevn
Copy link
MemberAuthor

Which one would you prefer: the current or.. c:namespace:: NULL?

@serhiy-storchaka
Copy link
Member

What do you prefer? I slightly prefer your initial layout, i.e. documentingPy_OpenCodeHookFunction "inside" the documentation forPyFile_SetOpenCodeHook, since the former is only used in the latter.

sobolevn reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

After comparing both, I am returning the initial layout, it is much easier to read 👍

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn and@serhiy-storchaka, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 23fb9f0777b054526b3b32f58e60b2a03132bf45 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 27, 2024
(cherry picked from commit23fb9f0)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-114639 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelJan 27, 2024
serhiy-storchaka pushed a commit that referenced this pull requestJan 27, 2024
(cherry picked from commit23fb9f0)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
@serhiy-storchaka
Copy link
Member

@sobolevn, this was backported to 3.11, but not to 3.12. Do you mind to make a backport?

@sobolevn
Copy link
MemberAuthor

Will do

sobolevn added a commit to sobolevn/cpython that referenced this pull requestSep 30, 2024
(cherry picked from commit23fb9f0)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-124786 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelSep 30, 2024
sobolevn added a commit that referenced this pull requestSep 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@hugovkhugovkAwaiting requested review from hugovk

Labels
docsDocumentation in the Doc dirskip issueskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp