Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-103323: Remove current_fast_get() unused parameter#114593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The current_fast_get() static inline function doesn't use its'runtime' parameter, so just remove it.
@ericsnowcurrently@colesbury@corona10: Would you mind to review this change? The change commitf8abfa3 modified current_fast_get(). Before the Python Thread State was retrieved from runtime, but it's no longer the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
IIRC, the main reason I left the parameter was to reduce churn. After that I didn't see any harm in leaving the parameter. That said, I'm not opposed to dropping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks more straightforward to me too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Merged, thanks for reviews. |
…14593)The current_fast_get() static inline function doesn't use its'runtime' parameter, so just remove it.
Uh oh!
There was an error while loading.Please reload this page.
The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.