Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Fix Sphinx warnings inwhatsnew/3.11.rst and related#114531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-101100: Fix Sphinx warnings inwhatsnew/3.11.rst and related#114531
Uh oh!
There was an error while loading.Please reload this page.
Conversation
whatsnew/3.11.rst and relatedwhatsnew/3.11.rst and relatedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It LGTM for main, but most of the changes should not be backported to 3.11, and some should not be backported to 3.12 either.
It is safer to not use automation, but re-do this work for 3.12 and 3..11 separately, to be sure that you do not remove a working reference.
Doc/whatsnew/3.11.rst Outdated
| @@ -1278,7 +1278,7 @@ This section covers specific optimizations independent of the | |||
| (Contributed by Stefan Behnel in :gh:`68264`.) | |||
| * Resizing lists is streamlined for the common case, | |||
| speeding up :meth:`list.append` by ≈15% | |||
| speeding up :meth:`!list.append` by ≈15% | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would left it as a reminder that we should add a reference to list.append, and not sweep it under cover.
| @@ -1604,7 +1604,7 @@ raw, adaptive bytecode containing quickened data. | |||
| New opcodes | |||
| ----------- | |||
| * :opcode:`ASYNC_GEN_WRAP`, :opcode:`RETURN_GENERATOR` and :opcode:`SEND`, | |||
| * :opcode:`!ASYNC_GEN_WRAP`, :opcode:`RETURN_GENERATOR` and :opcode:`SEND`, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It should not be backported to 3.11.
| * :func:`!importlib.resources.contents` | ||
| * :func:`!importlib.resources.is_resource` | ||
| * :func:`!importlib.resources.open_binary` | ||
| * :func:`!importlib.resources.open_text` | ||
| * :func:`!importlib.resources.read_binary` | ||
| * :func:`!importlib.resources.read_text` | ||
| * :func:`!importlib.resources.path` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It should not be backported to 3.12.
It could be perhaps simpler to make a patch for 3.11, then apply it to 3.12, fix new warnings, apply the new patch to main and fix the remaining warnings. It is how we did before Git. You can still use this sequence for fixing What's New for older versions. |
yep, good idea.
Interesting, will try that for the next What's New. 👍 |
Sure, we-added For that PR, https://docs.python.org/3/library/stdtypes.html#mutable-sequence-types Should we link Or add Or somewhere else? |
GH-114649 is a backport of this pull request to the3.12 branch. |
GH-114650 is a backport of this pull request to the3.11 branch. |
Uh oh!
There was an error while loading.Please reload this page.
Fix 51 warnings, mainly removals or renames.
📚 Documentation preview 📚:https://cpython-previews--114531.org.readthedocs.build/