Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91602: Add iterdump() support for filtering database objects.#114501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 14 commits intopython:mainfromfelixxm:issue-91602
Feb 6, 2024

Conversation

felixxm
Copy link
Contributor

@felixxmfelixxm commentedJan 23, 2024•
edited
Loading

  • Docs changes.
  • More tests.
  • Release notes.

@erlend-aasland
Copy link
Contributor

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a fullmake regen-all, in order to generate the needed static string object for thefilter keyword parameter.

@felixxm
Copy link
ContributorAuthor

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a fullmake regen-all, in order to generate the needed static string object for thefilter keyword parameter.

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

@erlend-aasland
Copy link
Contributor

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

Yeah, that's strange; I'd rebase ontomain andmake regen-all again 😄

@erlend-aasland
Copy link
Contributor

BTW, can you please usegit pull --noff main when aligning withmain, instead of force pushing? :)

@felixxm
Copy link
ContributorAuthor

Thanks for all your help, much appreciated. I will work on tests and docs later today.

erlend-aasland reacted with hooray emoji

@felixxmfelixxm changed the title[WIP] gh-91602: Add iterdump() support for filtering database objects.gh-91602: Add iterdump() support for filtering database objects.Jan 24, 2024
@felixxmfelixxm marked this pull request as ready for reviewJanuary 24, 2024 19:52
@felixxm
Copy link
ContributorAuthor

Now it's ready for review 🎉

@erlend-aasland
Copy link
Contributor

Very nice;321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

@felixxm
Copy link
ContributorAuthor

Very nice;321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

🍿

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The refcout refactoring in8cf51d4 is superb; I was just about to suggest it 🚀. I left a small comment regarding how we do the vector call.

When doing changes that affect reference counting, I normally do a refleak test locally:

$ ./python.exe -m test -R : test_sqlite3

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After this final change, we should be ready to land.

@felixxm
Copy link
ContributorAuthor

@erlend-aasland Thanks for all your help 🎁

erlend-aasland reacted with hooray emoji

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now for the docs; I left some comments :)

@erlend-aasland
Copy link
Contributor

!buildbot .refleak.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commite314153 🤖

The command will test the builders whose names match following regular expression:.*refleak.*

The builders matched are:

  • aarch64 RHEL8 Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • aarch64 Fedora Rawhide Refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • s390x Fedora Refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE RHEL7 Refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • AMD64 RHEL8 Refleaks PR
  • s390x RHEL7 Refleaks PR
  • AMD64 RHEL7 Refleaks PR

@erlend-aasland
Copy link
Contributor

Thebuildbot/s390x Fedora Rawhide Refleaks PR buildbot failure is unrelated to this PR.

@erlend-aaslanderlend-aasland merged commit1a10437 intopython:mainFeb 6, 2024
@erlend-aasland
Copy link
Contributor

Thanks a lot,@felixxm!

felixxm reacted with hooray emoji

@felixxmfelixxm deleted the issue-91602 branchFebruary 6, 2024 12:05
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
…python#114501)Add optional 'filter' parameter to iterdump() that allows a "LIKE"pattern for filtering database objects to dump.Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@felixxm@erlend-aasland@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp