Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inasyncio-task.rst#114469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromsobolevn:issue-101100-asyncio-task
Jan 24, 2024

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedJan 23, 2024•
edited by github-actionsbot
Loading

It used to be:

/Users/sobolev/Desktop/cpython2/Doc/library/asyncio-task.rst:837: WARNING: py:const reference target not found: FIRST_COMPLETED/Users/sobolev/Desktop/cpython2/Doc/library/asyncio-task.rst:840: WARNING: py:const reference target not found: FIRST_EXCEPTION/Users/sobolev/Desktop/cpython2/Doc/library/asyncio-task.rst:840: WARNING: py:const reference target not found: ALL_COMPLETED/Users/sobolev/Desktop/cpython2/Doc/library/asyncio-task.rst:846: WARNING: py:const reference target not found: ALL_COMPLETED

📚 Documentation preview 📚:https://cpython-previews--114469.org.readthedocs.build/

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

The drawback is that it renders the module name together with the constant name. But I think that it is not a big deal here. It may be a problem for longer names.

Copy link
Contributor

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@sobolevn. 🚢

@hugovkhugovk merged commit1e4f00e intopython:mainJan 24, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 1e4f00ebd8db44a031b61eed0803b4c3d731aed7 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 24, 2024
…114469)(cherry picked from commit1e4f00e)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-114518 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelJan 24, 2024
hugovk pushed a commit to hugovk/cpython that referenced this pull requestJan 24, 2024
…thonGH-114469)(cherry picked from commit1e4f00e)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-114519 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 24, 2024
hugovk pushed a commit that referenced this pull requestJan 24, 2024
… (#114518)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull requestJan 24, 2024
…thonGH-114469)(cherry picked from commit1e4f00e)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk added a commit that referenced this pull requestJan 24, 2024
… (#114519)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…4469)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…4469)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@willingcwillingcwillingc approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@sobolevn@hugovk@willingc@gvanrossum@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp