Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-112984: Fix link error on free-threaded Windows build#114455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The test_peg_generator test tried to link the python313_d.lib library,which failed because the library is now named python313t_d.lib. Theunderlying problem is that the "compiler" attribute was not set whenwe call get_libraries() from distutils.
!buildbot nogil |
bedevere-bot commentedJan 22, 2024
🤖 New build scheduled with the buildbot fleet by@colesbury for commitccfc91b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
cc@itamaro |
The relevant piece of distutils is this code: The |
We might also want to fix the library name upstream in distutils for the free-threaded build on non-MSVC compilers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks for the quick fix, Sam!
is this test not covered by the free-threaded CI? only buildbot?
Yes, |
the buildot is green on this PR (https://buildbot.python.org/all/#/builders/1295/builds/26) |
LGTM |
Thanks@zooba - would you please merge this PR? |
…nGH-114455)The test_peg_generator test tried to link the python313_d.lib library,which failed because the library is now named python313t_d.lib. Theunderlying problem is that the "compiler" attribute was not set whenwe call get_libraries() from distutils.
…nGH-114455)The test_peg_generator test tried to link the python313_d.lib library,which failed because the library is now named python313t_d.lib. Theunderlying problem is that the "compiler" attribute was not set whenwe call get_libraries() from distutils.
Uh oh!
There was an error while loading.Please reload this page.
The test_peg_generator test tried to link the python313_d.lib library, which failed because the library is now named python313t_d.lib. The underlying problem is that the cmd.compiler attribute was not set when we call get_libraries() from distutils.