Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-108303: Movesmtpd totest.support#114368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stmpd totest.supportsmtpd totest.supportvstinner commentedJan 22, 2024
This change should not be backported to 3.11: it was done in Python 3.12. |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
| fromsocketserverimport (ThreadingUDPServer,DatagramRequestHandler, | ||
| ThreadingTCPServer,StreamRequestHandler) | ||
| withwarnings.catch_warnings(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The change removeswith warnings.catch_warnings(): but apparently, it's useless. The test still pass without it:
$ ./python -Werror -m test test_logging test_smtplib -j0Using random seed: 15983232010:00:00 load avg: 0.96 Run 2 tests in parallel using 2 worker processes0:00:02 load avg: 1.37 [1/2] test_smtplib passed0:00:18 load avg: 1.22 [2/2] test_logging passed== Tests result: SUCCESS ==All 2 tests OK.Total duration: 18.9 secTotal tests: run=317 skipped=2Total test files: run=2/2Result: SUCCESSUpdate test_logging.py and test_smtplib.py.(cherry picked from commit8f5e7d7)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-114427 is a backport of this pull request to the3.12 branch. |
vstinner commentedJan 22, 2024
Merged, thanks. |
Update test_logging.py and test_smtplib.py.
Update test_logging.py and test_smtplib.py.
Uh oh!
There was an error while loading.Please reload this page.
This module was removed from stdlib in#93246
But, since it is not really a test file, it should have been moved to
Lib/test/support, notLib/test. This PR fixes that :)Now this is in line with
asyncoreandasynchat.