Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-108303: Remove the non-testLib/test/reperf.py#114356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 6 commits intopython:mainfromsobolevn:issue-108303-reperf
Sep 13, 2024

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedJan 20, 2024
edited by bedevere-appbot
Loading

Looks like this file was not touched for at least 12 years:https://github.com/python/cpython/commits/main/Lib/test/reperf.py

It does not seem useful. If it is, I can instead move it toTool/scripts.

Refs#114354

gpshead
gpshead previously requested changesJan 20, 2024
Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

apparently test_embed.py runs this code?

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn
Copy link
MemberAuthor

Ok, looks like it was used recently in#110769 by@ambv
I think that this has nothing to do withreperf, it just needs any rather complex module.

I propose to:

  • replacetest_embed's code to generate the module from code, so it would have no depedencies
  • still remove this module, we are cleaning things up, aren't we? :)
gpshead reacted with thumbs up emoji

@sobolevn
Copy link
MemberAuthor

I am now using another file instead ofreperf, it is already used intest_embed and is useful for this test as well: it prints the information, it has some imports, it does some checks.

So, we can remove the unneededreperf 🎉

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes and removed needs backport to 3.11only security fixes labelsMay 9, 2024
@encukouencukou dismissedgpshead’sstale reviewSeptember 9, 2024 14:44

test_embed no longer runs the code

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I'd rather not backport the removal.

@sobolevn
Copy link
MemberAuthor

sobolevn commentedSep 9, 2024
edited
Loading

@encukou looks like this PR#113601 influenced the CI. I fixed tests, so now both./python.exe -m test test_embed and./python.exe Lib/test/_test_embed_structseq.py pass:

» ./python.exe Lib/test/_test_embed_structseq.py            ..----------------------------------------------------------------------Ran 2 tests in 0.000sOKTests passed

Please, take another look :)

@encukouencukou merged commitd7e8339 intopython:mainSep 13, 2024
32 checks passed
@encukou
Copy link
Member

OK. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou approved these changes

@ambvambvAwaiting requested review from ambv

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@sobolevn@encukou@gpshead@ambv@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp