Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-114328: tty cbreak mode should not alter ICRNL#114335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CR -> NL mapping should be inherited in cbreak mode as OSes do notspecify altering it as part of their `stty` cbreak mode definition.
@gpshead, please see#114328 (comment) |
Updated further after conversation on the issue, see the discussion there. This should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If it is considered a bugfix, whyversionchanged
is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
It's unclear if it isreally needed (we normally don't), but it seems nice for our users to call the known issue out for a while. I'm okay with if these get deleted at a some later date. |
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
)The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.(cherry picked from commitfd49e22)Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-114410 is a backport of this pull request to the3.12 branch. |
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Uh oh!
There was an error while loading.Please reload this page.
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their
stty
cbreak mode definition.📚 Documentation preview 📚:https://cpython-previews--114335.org.readthedocs.build/