Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-114328: tty cbreak mode should not alter ICRNL#114335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 3 commits intopython:mainfromgpshead:lineprinters-its-the-70s
Jan 21, 2024

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedJan 19, 2024
edited by github-actionsbot
Loading

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of theirstty cbreak mode definition.


📚 Documentation preview 📚:https://cpython-previews--114335.org.readthedocs.build/

CR -> NL mapping should be inherited in cbreak mode as OSes do notspecify altering it as part of their `stty` cbreak mode definition.
@8vasu
Copy link
Contributor

@gpshead, please see#114328 (comment)

@gpsheadgpshead marked this pull request as draftJanuary 20, 2024 20:11
@gpsheadgpshead marked this pull request as ready for reviewJanuary 20, 2024 21:41
@gpshead
Copy link
MemberAuthor

Updated further after conversation on the issue, see the discussion there. This should be ready.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If it is considered a bugfix, whyversionchanged is needed?

Copy link
Contributor

@ronaldoussorenronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@gpshead
Copy link
MemberAuthor

If it is considered a bugfix, whyversionchanged is needed?

It's unclear if it isreally needed (we normally don't), but it seems nice for our users to call the known issue out for a while. I'm okay with if these get deleted at a some later date.

@gpsheadgpshead merged commitfd49e22 intopython:mainJan 21, 2024
@miss-islington-app
Copy link

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@gpsheadgpshead deleted the lineprinters-its-the-70s branchJanuary 21, 2024 23:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 21, 2024
)The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.(cherry picked from commitfd49e22)Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app
Copy link

GH-114410 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 21, 2024
gpshead added a commit that referenced this pull requestJan 21, 2024
…114410)The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.(cherry picked from commitfd49e22)Co-authored-by: Gregory P. Smith <greg@krypto.org>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@ronaldoussorenronaldoussorenronaldoussoren approved these changes

Assignees

@gpsheadgpshead

Labels
type-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@gpshead@8vasu@ronaldoussoren@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp