Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-79856: IDLE - separate config_key window and frame#11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 2 commits intopython:mainfromcsabella:configkey
Sep 30, 2022

Conversation

csabella
Copy link
Contributor

@csabellacsabella commentedJan 3, 2019•
edited by terryjreedy
Loading

Split dialog class into a Window class and Frame class and adjust tests to match.

@terryjreedyterryjreedy changed the titlebpo-35598: IDLE: Refactor configkey.py window and frame classbpo-35675: IDLE config_key - separate window and frame classesJan 7, 2019
Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rebase

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs to be rebased.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@iritkatrieliritkatriel added the pendingThe issue will be closed if no feedback is provided labelSep 30, 2022
@terryjreedyterryjreedy changed the titlebpo-35675: IDLE config_key - separate window and frame classesbpo-35675: IDLE config_key - separate window and frameSep 30, 2022
@terryjreedyterryjreedy removed awaiting changes pendingThe issue will be closed if no feedback is provided labelsSep 30, 2022
@terryjreedyterryjreedy self-assigned thisSep 30, 2022
@terryjreedyterryjreedy changed the titlebpo-35675: IDLE config_key - separate window and framebpo-35675: IDLE - separate config_key window and frameSep 30, 2022
@terryjreedyterryjreedy merged commit1cc308d intopython:mainSep 30, 2022
@miss-islington
Copy link
Contributor

Thanks@csabella for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelSep 30, 2022
@bedevere-bot
Copy link

GH-97683 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelSep 30, 2022
@bedevere-bot
Copy link

GH-97684 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2022
bpo-35598: IDLE: Refactor window and frame classCo-authored-by: Terry Jan Reedy <tjreedy@udel.edu>(cherry picked from commit1cc308d)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 30, 2022
bpo-35598: IDLE: Refactor window and frame classCo-authored-by: Terry Jan Reedy <tjreedy@udel.edu>(cherry picked from commit1cc308d)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull requestSep 30, 2022
bpo-35598: IDLE: Refactor window and frame classCo-authored-by: Terry Jan Reedy <tjreedy@udel.edu>(cherry picked from commit1cc308d)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull requestSep 30, 2022
bpo-35598: IDLE: Refactor window and frame classCo-authored-by: Terry Jan Reedy <tjreedy@udel.edu>(cherry picked from commit1cc308d)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@terryjreedyterryjreedy changed the titlebpo-35675: IDLE - separate config_key window and framegh-79856: IDLE - separate config_key window and frameSep 30, 2022
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestOct 2, 2022
bpo-35598: IDLE: Refactor window and frame classCo-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
mpage added a commit to mpage/cpython that referenced this pull requestFeb 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@auvipyauvipyauvipy requested changes

@iritkatrieliritkatrieliritkatriel left review comments

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy is a code owner

Assignees

@terryjreedyterryjreedy

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@csabella@bedevere-bot@miss-islington@iritkatriel@auvipy@the-knights-who-say-ni@terryjreedy@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp