Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-112075: Adapt more dict methods to Argument Clinic#114256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DinoV merged 13 commits intopython:mainfromDinoV:nogil_dict
Jan 23, 2024

Conversation

@DinoV
Copy link
Contributor

@DinoVDinoV commentedJan 18, 2024•
edited by bedevere-appbot
Loading

Uses argument clinic for the remainingdict methods which aren't using it yet. This will allow to use argument clinic's@critical_section consistently where it's appropriate.

Mostly straight forward, the most dramatic thing is that some of the argument clinic names overlap with existing names. Those existing names are just wrapped in public dict API so the functionality just moves into the public API.

@DinoVDinoVforce-pushed thenogil_dict branch 2 times, most recently from5e7a200 to72a78e4CompareJanuary 19, 2024 21:02
@rhettingerrhettinger removed their request for reviewJanuary 19, 2024 21:28
@erlend-aasland
Copy link
Contributor

Sorry to add remarks on the already amended docstrings, but let's avoid the CI churn of addressing this in another PR :)

DinoV reacted with thumbs up emoji

@erlend-aaslanderlend-aasland changed the titlegh-112075: Move more dict objects to argument clinic in preparation for using argument clinic for more lockinggh-112075: Adapt more dict methods to Argument ClinicJan 23, 2024
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with last round of suggestions applied.

DinoVand others added3 commitsJanuary 23, 2024 12:57
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
DinoVand others added4 commitsJanuary 23, 2024 12:58
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@DinoV
Copy link
ContributorAuthor

Thanks, I've appied them all!

erlend-aasland reacted with heart emoji

@DinoVDinoVenabled auto-merge (squash)January 23, 2024 20:59
@erlend-aasland
Copy link
Contributor

Thanks, I've appied them all!

Regen clinic ;)

@DinoVDinoV merged commitafe8f37 intopython:mainJan 23, 2024
@erlend-aasland
Copy link
Contributor

@DinoV, next time, can you please clean up the commit message before merging?

@DinoV
Copy link
ContributorAuthor

@DinoV, next time, can you please clean up the commit message before merging?

Ahh yes, sorry! :(

erlend-aasland reacted with heart emoji

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…14256)* Move more dict objects to argument clinic* Improve doc strings* More doc string improvements* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>---------Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…14256)* Move more dict objects to argument clinic* Improve doc strings* More doc string improvements* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>* Update Objects/dictobject.cCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>---------Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@methanemethanemethane left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DinoV@erlend-aasland@methane
[8]ページ先頭
©2009-2025 Movatter.jp