Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.12] Check for valid tp_version_tag in specializer (gh-89811)#114216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lazorchakp
Copy link
Contributor

@lazorchakplazorchakp commentedJan 17, 2024•
edited by bedevere-appbot
Loading

Backports#113558 to 3.12. Also backports#113953, which fixes a bug in the original PR.

  • I removed two test cases fromtest_type_cache for specializations that only exist on main
  • I also need to backport this to 3.11, but that is currently proving to be a bit more complicated than I would have hoped

@lazorchakplazorchakp marked this pull request as ready for reviewJanuary 17, 2024 23:39
@lazorchakp
Copy link
ContributorAuthor

@Fidget-Spinner keeping you in the loop for this. I'm still working on the 3.11 backport

Fidget-Spinner reacted with thumbs up emoji

@lazorchakplazorchakp changed the title[3.12] Check for valid tp_version_tag in specializer (gh-89811)[3.12] Check for valid tp_version_tag in specializer (gh-113558, gh-113953)Jan 17, 2024
@lazorchakplazorchakp changed the title[3.12] Check for valid tp_version_tag in specializer (gh-113558, gh-113953)[3.12] Check for valid tp_version_tag in specializer (gh-89811)Jan 17, 2024
@Fidget-SpinnerFidget-Spinner added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJan 18, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@Fidget-Spinner for commit321137e 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJan 18, 2024
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These buildbots fail on main too, so this PR should be fine. Thanks!

lazorchakp reacted with thumbs up emoji
@Fidget-SpinnerFidget-Spinner merged commitae2a25b intopython:3.12Jan 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lazorchakp@bedevere-bot@Fidget-Spinner
[8]ページ先頭
©2009-2025 Movatter.jp