Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-99334: Explain thatPurePath.is_relative_to() is purely lexical.#114031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AA-Turner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Perhaps you could add a note that users may wish to only call it with resolved / normalised / casefolded / etc paths, and provide a brief sketch of doing so?
barneygale commentedJan 23, 2024
Thanks for the review!
It's hard to give good advice, because there are several edge cases that may or may not be relevant depending on user need. (tbh I'd rather |
AA-Turner commentedJan 23, 2024
I think the actual change here is fine to merge -- the comment was just the cherry on top, but it would simply add confusion then best avoided -- and the reader can infer that no path processing is done from the current text as proposed. A |
barneygale commentedJan 23, 2024
Thanks again! |
Thanks@barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…xical. (pythonGH-114031)(cherry picked from commit3a61d24)Co-authored-by: Barney Gale <barney.gale@gmail.com>
Sorry,@barneygale, I could not cleanly backport this to |
GH-114460 is a backport of this pull request to the3.12 branch. |
…xical. (python#114031)(cherry picked from commit3a61d24)
…rely lexical. (pythonGH-114031).(cherry picked from commit3a61d24)Co-authored-by: Barney Gale <barney.gale@gmail.com>
GH-114461 is a backport of this pull request to the3.11 branch. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--114031.org.readthedocs.build/