NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.12] gh-113903: Fix an IDLE configdialog test (GH-113973)#113974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

terryjreedy merged 1 commit intopython:3.12frommiss-islington:backport-c4992f4-3.12

Jan 12, 2024

Merged

[3.12] gh-113903: Fix an IDLE configdialog test (GH-113973)#113974

terryjreedy merged 1 commit intopython:3.12frommiss-islington:backport-c4992f4-3.12

Jan 12, 2024

Conversation

Copy link

Contributor

miss-islington commentedJan 12, 2024•
edited by bedevere-appbot
Loading

test_configdialog.HighPageTest.test_highlight_target_text_mouse fails
if a line of the Highlight tab text sample is not visible. If so, bbox()
in click_char() returns None and the unpacking iteration fails.

This occurred on a Devuan Linux system. Fix by moving the
'see character' call inside click_char, just before the bbox call.

Also, reduce the click_char calls to just one per tag name and
replace the other nested function with a dict comprehension.
(cherry picked from commitc4992f4)

Co-authored-by: Terry Jan Reedytjreedy@udel.edu

Issue:test_idle fails on Devuan 5 Linux #113903

pythongh-113903: Fix an IDLE configdialog test (pythonGH-113973)

84640ab

test_configdialog.HighPageTest.test_highlight_target_text_mouse failsif a line of the Highlight tab text sample is not visible. If so, bbox()in click_char() returns None and the unpacking iteration fails.This occurred on a Devuan Linux system. Fix by moving the'see character' call inside click_char, just before the bbox call.Also, reduce the click_char calls to just one per tag name andreplace the other nested function with a dict comprehension.(cherry picked from commitc4992f4)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>