Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now only unbinds "funcid"#113955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:tkinter-tag_unbind-funcidFeb 4, 2024
Merged
gh-113951: Tkinter: "tag_unbind(tag, sequence, funcid)" now only unbinds "funcid"#113955
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:tkinter-tag_unbind-funcidFeb 4, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…y unbinds "funcid"Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 4, 2024
…y unbinds "funcid" (pythonGH-113955)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.(cherry picked from commit7e42fdd)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-114997 is a backport of this pull request to the3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 4, 2024
…y unbinds "funcid" (pythonGH-113955)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.(cherry picked from commit7e42fdd)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-114998 is a backport of this pull request to the3.11 branch. |
serhiy-storchaka added a commit that referenced this pull requestFeb 4, 2024
…ly unbinds "funcid" (GH-113955) (GH-114997)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.(cherry picked from commit7e42fdd)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestFeb 4, 2024
…ly unbinds "funcid" (GH-113955) (GH-114998)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.(cherry picked from commit7e42fdd)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…y unbinds "funcid" (pythonGH-113955)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
…y unbinds "funcid" (pythonGH-113955)Previously, "tag_unbind(tag, sequence, funcid)" methods of Text andCanvas widgets destroyed the current binding for "sequence", leaving"sequence" unbound, and deleted the "funcid" command.Now they remove only "funcid" from the binding for "sequence", keepingother commands, and delete the "funcid" command.They leave "sequence" unbound only if "funcid" was the last bound command.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Previously, "tag_unbind(tag, sequence, funcid)" methods of Text and Canvas widgets destroyed the current binding for "sequence", leaving "sequence" unbound, and deleted the "funcid" command.
Now they remove only "funcid" from the binding for "sequence", keeping other commands, and delete the "funcid" command.
They leave "sequence" unbound only if "funcid" was the last bound command.