NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-103092: Ensure`_ctypes.c` static types are accessed via global state#113857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 5 commits intopython:mainfromneonene:ctypes_ready

Jan 22, 2024

Merged

gh-103092: Ensure`_ctypes.c` static types are accessed via global state#113857

vstinner merged 5 commits intopython:mainfromneonene:ctypes_ready

Jan 22, 2024

Conversation

Copy link

Contributor

neonene commentedJan 9, 2024•
edited by bedevere-appbot
Loading

This sets in place thectypes_state *st = GLOBAL_STATE() statements to make the coming PRs smaller. Suggested by@encukou:#113630 (comment)

cc@erlend-aasland

Issue:Isolate Stdlib Extension Modules #103092

bedevere-appbot added the awaiting review label

Jan 9, 2024

bedevere-appbot mentioned this pull request

Jan 9, 2024

Isolate Stdlib Extension Modules#103092

Open

25 tasks

neonene changed the title~~gh-103092: Ensure '_ctypes.c' static types are accessed via global state~~gh-103092: Ensure_ctypes.c static types are accessed via global state

Jan 9, 2024

Copy link

Contributor

erlend-aasland commentedJan 9, 2024

See also ongoing work by@aisk in#113620. Perhaps you could coordinate your efforts?

erlend-aasland requested review fromerlend-aasland andencukou

January 9, 2024 21:05

Copy link

Member

encukou commentedJan 10, 2024

@erlend-aasland, do you want to review these two PRs?
If you merge one I'll be happy to resolve the conflicts on the other one.

Copy link

Contributor

erlend-aasland commentedJan 10, 2024

@erlend-aasland, do you want to review these two PRs? If you merge one I'll be happy to resolve the conflicts on the other one.

Sure, I'll get to it later today.

erlend-aasland self-assigned this

Jan 10, 2024

erlend-aasland reviewed

Jan 17, 2024

View reviewed changes

Modules/_ctypes/callbacks.c OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

neonene commentedJan 17, 2024

Done. I'll update this after#113620 is merged.

neonene closed this

Jan 18, 2024

neonene changed the title~~gh-103092: Ensure_ctypes.c static types are accessed via global state~~Ensure_ctypes.c static types are accessed via global state

Jan 18, 2024

Add pointers to ctypes_state

401685c

neonene reopened this

Jan 18, 2024

neonene changed the title~~Ensure_ctypes.c static types are accessed via global state~~gh-103092: Ensure_ctypes.c static types are accessed via global state

Jan 18, 2024

Merge branch 'python:main' into ctypes_ready

2564bc1

Copy link

ContributorAuthor

neonene commentedJan 18, 2024

I think this is ready for review. Sorry for mistakenly wiping out old commits (from web).

Actual diff witha1ade06:

--- Modules/_ctypes/_ctypes.c+++ Modules/_ctypes/_ctypes.c@@ -128,13 +128,6 @@-static PyTypeObject UnionType_Type; static PyTypeObject Union_Type; static PyTypeObject Struct_Type; static PyTypeObject Simple_Type;  ctypes_state global_state = {     .PyCStgDict_Type = &PyCStgDict_Type,-    .PyCStructType_Type = &PyCStructType_Type,-    .UnionType_Type = &UnionType_Type,-    .PyCPointerType_Type = &PyCPointerType_Type,-    .PyCArrayType_Type = &PyCArrayType_Type,-    .PyCSimpleType_Type = &PyCSimpleType_Type,-    .PyCFuncPtrType_Type = &PyCFuncPtrType_Type,