Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-81094: Refer to PEP 318 in compound_statements.rst#113588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Rasputin2
Copy link
Contributor

@Rasputin2Rasputin2 commentedDec 30, 2023
edited by hugovk
Loading

@ghost
Copy link

ghost commentedDec 30, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news awaiting review labelsDec 30, 2023
@hugovkhugovk changed the titlegh-80914: Adds Reference to PEP 318 in compound_statements.rstgh-81094: Adds Reference to PEP 318 in compound_statements.rstDec 30, 2023
@hugovkhugovk added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsDec 30, 2023
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, looks good!

Let's give a bit of time before merge in case@slateny want to check it too.

@Rasputin2
Copy link
ContributorAuthor

Rasputin2 commentedDec 31, 2023 via email

I just did another pull request to fix the sentence.  Let me know if you want me to do that other change. I am working tomorrow anyway.I am eager to contribute, as I work with Machine Learning / AI stuff and business process automation, and so I have ideas about more advanced stuff to contribute (i.e., to things like openpyxl and python-pptx and natural language processing), but I realize I have to start with the easy stuff and then work my way up.John D. McDonaldPJ Consulting LLCPh.      1-312-945-3518Mobile 1-312-479-2854 On Saturday, December 30, 2023 at 10:49:35 PM CST, Stanley ***@***.***> wrote:@slateny commented on this pull request.In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving annotations in a string form at runtime instead of eager evaluation.+ :pep:`318` - Decorators for Functions and Methods+ Function and method decorators were introduced.LGTM as well, thanks. Optionally, it might be useful to mirror the "Class definitions" section and also reference PEP 3129 under the "Function definitions" block with something like⬇️ Suggested change- Function and method decorators were introduced.+ Function and method decorators were introduced. Class decorators were introduced in :pep:`3129`.I'll let Hugo decide whether that addition's useful or not 🙂Since we're changing this section anyways, on line 1365 there's a missing period after variables and instance variables that my suggestion can't quite reach. If you could give that a quick fix, that'd be great too!—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

@Rasputin2Rasputin2force-pushed theIssue_80914_Adding_PEP_318_Reference branch fromb6b5be4 to5c2ec84CompareDecember 31, 2023 20:22
@Rasputin2
Copy link
ContributorAuthor

Rasputin2 commentedDec 31, 2023 via email

Ok, I think (hope) I did this correctly.  See below.  Another reason for volunteering is I am hoping to improve my Github skills.  Like I didn't even know you could do more than one commit per pull request.John D. McDonaldPJ Consulting LLCPh.      1-312-945-3518Mobile 1-312-479-2854 On Sunday, December 31, 2023 at 09:21:40 AM CST, Hugo van Kemenade ***@***.***> wrote:@hugovk commented on this pull request.In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving annotations in a string form at runtime instead of eager evaluation.+ :pep:`318` - Decorators for Functions and Methods+ Function and method decorators were introduced.Sure, let's include this.@Rasputin2 Please could you add that? You can click the "Commit suggestion" button to apply this.And add the period as a new commit in this PR, rather than a new one.Thanks!—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Rasputin2and others added2 commitsJanuary 1, 2024 16:19
@Rasputin2
Copy link
ContributorAuthor

Rasputin2 commentedJan 1, 2024 via email

I believe I accepted these changes as part of the same PR.  So, I think this is done, unless you guys disagree.John D. McDonaldPJ Consulting LLCPh.      1-312-945-3518Mobile 1-312-479-2854 On Monday, January 1, 2024 at 03:08:05 AM CST, Hugo van Kemenade ***@***.***> wrote:@hugovk commented on this pull request.In Doc/reference/compound_stmts.rst:
:pep:`563` - Postponed Evaluation of Annotations Support for forward references within annotations by preserving annotations in a string form at runtime instead of eager evaluation.+ :pep:`318` - Decorators for Functions and Methods+ Function and method decorators were introduced.Please add this bit:⬇️ Suggested change- Function and method decorators were introduced.+ Function and method decorators were introduced.+ Class decorators were introduced in :pep:`3129`.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@hugovkhugovk changed the titlegh-81094: Adds Reference to PEP 318 in compound_statements.rstgh-81094: Refer to PEP 318 in compound_statements.rstJan 2, 2024
@hugovkhugovk merged commit8ff44f8 intopython:mainJan 2, 2024
@miss-islington-app
Copy link

Thanks@Rasputin2 for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2024
…-113588)(cherry picked from commit8ff44f8)Co-authored-by: John D. McDonald <43117960+Rasputin2@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-113643 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 2, 2024
…-113588)(cherry picked from commit8ff44f8)Co-authored-by: John D. McDonald <43117960+Rasputin2@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-113644 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelJan 2, 2024
hugovk added a commit that referenced this pull requestJan 2, 2024
…) (#113644)Co-authored-by: John D. McDonald <43117960+Rasputin2@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull requestJan 2, 2024
…) (#113643)Co-authored-by: John D. McDonald <43117960+Rasputin2@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
…13588)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…13588)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…13588)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@slatenyslatenyslateny left review comments

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Rasputin2@hugovk@slateny

[8]ページ先頭

©2009-2025 Movatter.jp