Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix Sphinx warnings inc-api/structures.rst#113564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedDec 29, 2023•
edited
Loading

Fix these two warnings:

Doc/c-api/structures.rst:519: WARNING: c:type reference target not found: PyTypeSlotDoc/c-api/structures.rst:524: WARNING: c:type reference target not found: PyTypeSlot

They're typos, should bePyType_Slot. See PR#103511 where they were added (to 3.12, no backport needed for 3.11).

That leaves these two warnings in this file:

Doc/c-api/structures.rst:656: WARNING: c:identifier reference target not found: getterDoc/c-api/structures.rst:660: WARNING: c:identifier reference target not found: setter

I'm not sure what to do with these, any ideas? (Added in PR#100054, also in 3.12.)

📚 Documentation preview 📚:https://cpython-previews--113564.org.readthedocs.build/

@hugovk
Copy link
MemberAuthor

@encukou Any suggestion for thegetter/setter warnings here?

@encukou
Copy link
Member

They're defined a few lines below. (Definitely not the first place I looked!)

I hope you're OK with me pushing a fix-up directly to the PR.
I also found a nearby improvement to make: for struct fields,NULL works better than “omitted”.

@hugovk
Copy link
MemberAuthor

I am, thank you!

@hugovkhugovk merged commit51d9068 intopython:mainJan 24, 2024
@hugovkhugovk deleted the docs-fix-sphinx-warnings-c-api-structures branchJanuary 24, 2024 13:40
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 24, 2024
…nGH-113564)(cherry picked from commit51d9068)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

GH-114527 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJan 24, 2024
hugovk added a commit that referenced this pull requestJan 24, 2024
…13564) (#114527)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…n#113564)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…n#113564)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@encukou
[8]ページ先頭
©2009-2025 Movatter.jp