Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-67693: Fix urlunparse() and urlunsplit() for URIs with path starting with multiple slashes and no authority#113563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It fixes also more serious security issue#67693. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code changes and tests look good to me.
Uh oh!
There was an error while loading.Please reload this page.
| ('//path/to/file', | ||
| ('', 'path', '/to/file', '', '', ''), | ||
| ('', 'path', '/to/file', '', '')), | ||
| ('////path/to/file', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case was broken.
| ('scheme://path/to/file', | ||
| ('scheme', 'path', '/to/file', '', '', ''), | ||
| ('scheme', 'path', '/to/file', '', '')), | ||
| ('scheme:////path/to/file', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case was broken.
| ('file:///tmp/junk.txt', | ||
| ('file', '', '/tmp/junk.txt', '', '', ''), | ||
| ('file', '', '/tmp/junk.txt', '', '')), | ||
| ('file:////tmp/junk.txt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case was broken.
| ('file:////tmp/junk.txt', | ||
| ('file', '', '//tmp/junk.txt', '', '', ''), | ||
| ('file', '', '//tmp/junk.txt', '', '')), | ||
| ('file://///tmp/junk.txt', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This case was broken.
sethmlarson approved these changesMay 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. |
GH-119025 is a backport of this pull request to the3.11 branch. |
GH-119026 is a backport of this pull request to the3.10 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestMay 14, 2024
…h path starting with multiple slashes and no authority (pythonGH-113563)(cherry picked from commite237b25)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-119027 is a backport of this pull request to the3.9 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestMay 14, 2024
… path starting with multiple slashes and no authority (pythonGH-113563)(cherry picked from commite237b25)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-119028 is a backport of this pull request to the3.8 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestMay 14, 2024
…h path starting with multiple slashes and no authority (pythonGH-113563)(cherry picked from commite237b25)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestMay 14, 2024
serhiy-storchaka added a commit that referenced this pull requestMay 14, 2024
Closed
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull requestJun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.This currently affects only 3.12 and 3.13 but there are other backportsfor that change in review upstream, so we'll likely need to update thisin the future.[1]python/cpython#113563
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull requestJun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.This currently affects only 3.12 and 3.13 but there are other backportsfor that change in review upstream, so we'll likely need to update thisin the future.[1]python/cpython#113563
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull requestJun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.This currently affects only 3.12 and 3.13 but there are other backportsfor that change in review upstream, so we'll likely need to update thisin the future.[1]python/cpython#113563
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull requestJun 23, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.This currently affects only 3.12 and 3.13 but there are other backportsfor that change in review upstream, so we'll likely need to update thisin the future.[1]python/cpython#113563
matthewhughes934 pushed a commit to matthewhughes934/pip that referenced this pull requestJun 24, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.The sample URL used to check this behaviour was taken from a test in theupstream change (with the new behaviour this URL will round-tripparsing)[1]python/cpython#113563
pradyunsg pushed a commit to pypa/pip that referenced this pull requestJun 25, 2024
There was a behavioural change to `urllib.parse.urlunparse`[1] thataffects some of our tests on Windows. With the understanding that thenew behaviour is indeed desired, split up some tests relying on thisbehaviour depending on the version of Python.The sample URL used to check this behaviour was taken from a test in theupstream change (with the new behaviour this URL will round-tripparsing)[1]python/cpython#113563
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…starting with multiple slashes and no authority (pythonGH-113563)
This was referencedJul 21, 2024
ambv pushed a commit that referenced this pull requestSep 4, 2024
ambv pushed a commit that referenced this pull requestSep 4, 2024
ambv added a commit that referenced this pull requestSep 4, 2024
ambv added a commit that referenced this pull requestSep 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Based on#15297.
Co-authored-by: Ashwin Ramaswamiaramaswamis@gmail.com