Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-112898: Fix double close dialog with warning about unsafed files#113513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
ronaldoussoren wants to merge18 commits intopython:mainChoose a base branch fromronaldoussoren:gh-112898-double-dialog
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
18 commits Select commitHold shift + click to select a range
a0bb7ab
gh-112898: Fix double close dialog with warning about unsafed files
ronaldoussoreneda5750
Actually work with various quit events (menu, shortcut, osascript)
ronaldoussoren3686a65
Remove comment that is no longer needed
ronaldoussorenb305b36
Restore working code path
ronaldoussorena84a2d7
Crude hack to make sure the quit command is called
ronaldoussoren0ce7d86
Remove unnecesary key setup
ronaldoussorence08ba0
Remove unnecessary import
ronaldoussoren92c1206
typo
ronaldoussoren4cefbea
Getting lost ...
ronaldoussorenbbdee67
Restructure code to avoid creating a temporary ``tkinter.Tk``
ronaldoussorenab7800a
Document why the close-all-windows keybinding is removed on macOS
ronaldoussoren63087e3
Fix test failure and lint warning
ronaldoussoren4c7ad17
Merge branch 'main' into gh-112898-double-dialog
ronaldoussoren4794ee7
The changes to macosx.py broke some of the tests
ronaldoussoren8d9a7f0
Fix copy&paste error
ronaldoussoren7ccc8fa
Merge branch 'main' into gh-112898-double-dialog
terryjreedybf6f348
review comments
ronaldoussoren60ccabb
Merge branch 'gh-112898-double-dialog' of github.com:ronaldoussoren/c…
ronaldoussorenFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
review comments
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitbf6f348c40228dda24edec349b324ab1d13b00cd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.