Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-65701: document that freeze doesn't work with framework builds on macOS#113352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.
I looked into adding a test for this, but in the end skipped this: the test machinery for the freeze tool performs a build & install into a temporary directory and that doesn't work with framework builds either. That's not something I want to debug further given that the test would only check that the tool doesnot work. |
erlend-aasland approved these changesDec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Added a suggestion to use the:program: role.
Misc/NEWS.d/next/macOS/2023-12-21-10-20-41.gh-issue-65701.Q2hNbN.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…bN.rstCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Thanks@ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks@ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 21, 2023
…ds on macOS (pythonGH-113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.(cherry picked from commitdf1eec3)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-113361 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 21, 2023
…ds on macOS (pythonGH-113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.(cherry picked from commitdf1eec3)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
GH-113362 is a backport of this pull request to the3.12 branch. |
ronaldoussoren added a commit that referenced this pull requestDec 22, 2023
…lds on macOS (GH-113352) (#113362)gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352)*gh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.(cherry picked from commitdf1eec3)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
ronaldoussoren added a commit that referenced this pull requestDec 22, 2023
…lds on macOS (GH-113352) (#113361)gh-65701: document that freeze doesn't work with framework builds on macOS (GH-113352)*gh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.(cherry picked from commitdf1eec3)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull requestDec 26, 2023
…ds on macOS (python#113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
…ds on macOS (python#113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…ds on macOS (python#113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…ds on macOS (python#113352)*pythongh-65701: document that freeze doesn't work with framework builds on macOSThe framework install is inherently incompatible with freeze. Documentthat that freeze doesn't work with framework builds and bail outearly when trying to run freeze anyway.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The framework install is inherently incompatible with freeze. Document that that freeze doesn't work with framework builds and bail out early when trying to run freeze anyway.