Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-112305: Fix check-clean-src to detect frozen_modules .h files.#113344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.
Easily cut and pasteable on its own line, with less repetition.
erlend-aasland approved these changesDec 21, 2023
Contributor
erlend-aasland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thanks!
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-113346 is a backport of this pull request to the3.12 branch. |
GH-113347 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 21, 2023
…s. (pythonGH-113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.(cherry picked from commit103c4ea)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 21, 2023
…s. (pythonGH-113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.(cherry picked from commit103c4ea)Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull requestDec 21, 2023
…es. (GH-113344) (#113347)gh-112305: Fix check-clean-src to detect frozen_modules .h files. (GH-113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.(cherry picked from commit103c4ea)Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull requestDec 21, 2023
…es. (GH-113344) (#113346)gh-112305: Fix check-clean-src to detect frozen_modules .h files. (GH-113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.(cherry picked from commit103c4ea)Co-authored-by: Gregory P. Smith <greg@krypto.org>
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull requestDec 26, 2023
…s. (python#113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.
kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
…s. (python#113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…s. (python#113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…s. (python#113344)A typo left this check broken so many of us who do out-of-tree buildswere seeing strange failures due to bad `Python/frozen_modules/*.h`files being picked up from the source tree and used at build time fromdifferent Python versions leading to errors like:`Fatal Python error: _PyImport_InitCore: failed to initialize importlib`Or similar once our build got to an "invoke the interpreter"bootstrapping step due to incorrect bytecode being embedded.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
A typo left this check broken so many of us who do out-of-tree builds were seeing strange failures due to bad
Python/frozen_modules/*.hfiles being picked up from the source tree and used at build time from different Python versions leading to errors like:Fatal Python error: _PyImport_InitCore: failed to initialize importlibOr similar once our build got to an "invoke the interpreter" bootstrapping step due to incorrect bytecode being embedded.