Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-113119: Fix the macOS framework installer build#113268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 2 commits intopython:mainfromgpshead:issue113117-macos-framework
Dec 19, 2023

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedDec 19, 2023•
edited
Loading

@gpsheadgpshead changed the titlegh-113117: Fix the macOS framework installer buildgh-113119: Fix the macOS framework installer buildDec 19, 2023
@gpsheadgpshead marked this pull request as ready for reviewDecember 19, 2023 04:54
@gpshead
Copy link
MemberAuthor

Related: since this didn't come up in testing for the original change, it sounds like we're missing--enable-framework in either CI or buildbots?

@gpsheadgpshead added 3.13bugs and security fixes release-blocker labelsDec 19, 2023
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for the quick fix.

@gpshead
Copy link
MemberAuthor

I manually tested that building works on a mac with a configure --enable-framework - FWIW there appear to be a pile of tests that do not pass in framework builds regardless of this (looks environment related when launching python as a child process).

@gpsheadgpshead merged commitc895403 intopython:mainDec 19, 2023
@gpsheadgpshead deleted the issue113117-macos-framework branchDecember 19, 2023 05:18
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull requestDec 26, 2023
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
`--enable-framework` builds were failing.  we apparently do not have good CI & buildbot coverage here.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ned-deilyned-deilyned-deily approved these changes

Assignees
No one assigned
Labels
3.13bugs and security fixesOS-macrelease-blockerskip newstype-bugAn unexpected behavior, bug, or error
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@gpshead@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp