Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-113174: Sync with importlib_metadata 7.0#113175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jaraco
Copy link
Member

@jaracojaraco commentedDec 15, 2023•
edited by bedevere-appbot
Loading

@hugovk
Copy link
Member

Sync with importlib_metadata 7.0, including improved type annotations, fixed
issue with symlinked packages inpackage_distributions, added
EntryPoints.__repr__, introduced thediagnose script, added
Distribution.origin property, and removed deprecatedEntryPoint
access by numeric index (tuple behavior).

Will there be docs changes in this PR or another?

@jaraco
Copy link
MemberAuthor

Will there be docs changes in this PR or another?

I've added docs in b610b6d. I chose not to mention some of the changes as they seemed incidental enough not to affect most users.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would this also benefit from an entry in What's New in Python 3.13?

@jaracojaracoforce-pushed thefeature/113174-importlib-metadata-7.0 branch from5914c78 toaa23e5aCompareDecember 15, 2023 16:16
@jaraco
Copy link
MemberAuthor

Would this also benefit from an entry in What's New in Python 3.13?

Perhaps. I'd consider mentioning theEntryPoint.__getitem__ removal and newDistribution.origin property, though I expect most users not to care much. Overall, I'm thinking it'd be more noise than value, so I'll propose not to add anything, but I'd be happy to add something if anyone feels otherwise.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with@hugovk that the removal ofEntryPoint.__getitem__ should be mentioned in "What's New". It doesn't need to be a prominent mention near the top of the document, but we should try to make sure that all backwards-incompatible changes are mentioned somewhere in that document, in my opinion.

jaraco reacted with thumbs up emoji
@brettcannonbrettcannon removed their request for reviewDecember 19, 2023 19:18
@jaraco
Copy link
MemberAuthor

Today I learned about the syntax (docs). The exclamation point means to ignore EntryPoint because it isn't documented.

@jaraco
Copy link
MemberAuthor

Thanks for the review. Merging, but happy to revisit if needed.

@jaracojaraco merged commit2d91409 intopython:mainDec 21, 2023
@jaracojaraco deleted the feature/113174-importlib-metadata-7.0 branchDecember 21, 2023 20:04
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull requestDec 26, 2023
* Sync with importlib_metadata 7.0.0* Add blurb* Update docs to reflect changes.* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add what's new for removed __getattr__* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add exclamation point, as that seems to be used for other classes.---------Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ambv
Copy link
Contributor

ambv commentedJan 2, 2024

There's some tests that are failing on Windows for this change. The build that introduced the failure is the one with this PR merged:
https://buildbot.python.org/all/#/builders/1079/builds/3009

@ambv
Copy link
Contributor

I worked around the problem by enablingSeCreateSymbolicLinkPrivilege for the buildbot user, but ultimately I believe the test should be skipped for users without this privilege set.

kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
* Sync with importlib_metadata 7.0.0* Add blurb* Update docs to reflect changes.* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add what's new for removed __getattr__* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add exclamation point, as that seems to be used for other classes.---------Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
* Sync with importlib_metadata 7.0.0* Add blurb* Update docs to reflect changes.* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add what's new for removed __getattr__* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add exclamation point, as that seems to be used for other classes.---------Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
* Sync with importlib_metadata 7.0.0* Add blurb* Update docs to reflect changes.* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add what's new for removed __getattr__* Link datamodel docs for object.__getitem__Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>* Add exclamation point, as that seems to be used for other classes.---------Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jaraco@hugovk@ambv@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp