Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-113119 fix environment handling in subprocess.Popen when posix_spawn is used#113120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code looks good, can you add a NEWS entry (step 8 inhttps://devguide.python.org/) and mention theos.posix_spawn feature of acceptingenv=None to mean "use the current process environment" inDoc/whatsnew/3.13.rst?
Thanks for the review. I added a NEWS fragment and whatsnew entry as per your suggestion. |
…ix_spawn is used (python#113120)* Allow posix_spawn to inherit environment form parent environ variable.With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
…ix_spawn is used (python#113120)* Allow posix_spawn to inherit environment form parent environ variable.With this change, posix_spawn call can behave similarly to execv with regards to environments when used in subprocess functions.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#113119 .
📚 Documentation preview 📚:https://cpython-previews--113120.org.readthedocs.build/