Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-113117: Support posix_spawn in subprocess.Popen with close_fds=True#113118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
serhiy-storchaka approved these changesDec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Please add a NEWS and What's New entries.
Uh oh!
There was an error while loading.Please reload this page.
gpshead approved these changesDec 15, 2023
gpshead approved these changesDec 17, 2023
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
bedevere-bot commentedDec 17, 2023
Gives a more useful description and mentions that it can be turned off but that we'd like to hear from anyone doing so.
(the joys of using the github web editor)
This describes the module changes in module sections and makes theOptimizations section brief, referring back up to the subprocessmodule.
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull requestDec 26, 2023
…ds=True (python#113118)Add support for `os.POSIX_SPAWN_CLOSEFROM` and`posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module usethem when available. This means `posix_spawn` can now be used in the default`close_fds=True` situation on many platforms.Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…ds=True (python#113118)Add support for `os.POSIX_SPAWN_CLOSEFROM` and`posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module usethem when available. This means `posix_spawn` can now be used in the default`close_fds=True` situation on many platforms.Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…ds=True (python#113118)Add support for `os.POSIX_SPAWN_CLOSEFROM` and`posix_spawn_file_actions_addclosefrom_np` and have the `subprocess` module usethem when available. This means `posix_spawn` can now be used in the default`close_fds=True` situation on many platforms.Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
I just discover this optimization by reading What's New in Python 3.13. Congrats@kulikjak, it's a great step forward! I didn't know that Linux supported this feature! |
^^ Thanks! Though I am not sure how much Linux will benefit, considering it has vfork. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--113118.org.readthedocs.build/