Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix Sphinx nitpicks inlibrary/collections.abc.rst#113116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commentedDec 14, 2023•
edited by github-actionsbot
Loading

@rhettinger
Copy link
Contributor

rhettinger commentedDec 14, 2023•
edited
Loading

Please leave the double-back-ticks as they are now. They were intentionally just inline code and not links which as no value and are distracting to a reader.

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
MemberAuthor

Please leave the double-back-ticks as they are now. They were intentionally just inline code and not links which as no value and are distracting to a reader.

Sure -- I've reverted those changes

testing an interface by verifying the required methods are present
and have not been set to :const:`None`. This only works for simple
interfaces. More complex interfaces require registration or direct
subclassing.

.. [2] Checking ``isinstance(obj, Iterable)`` detects classes that are
registered as :class:`Iterable` or that have an :meth:`__iter__`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Same here.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the added link here (to__iter__ methods) is pertinent and useful, as it relates to the definition of what an iterable is. The other methods in this footnote also have links to their documentation.

@AlexWaygoodAlexWaygood merged commit006355b intopython:mainDec 14, 2023
@AlexWaygoodAlexWaygood deleted the collections-abc-nitpicks branchDecember 14, 2023 19:25
@miss-islington-app
Copy link

Thanks@AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app
Copy link

GH-113136 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 14, 2023
…pythonGH-113116)(cherry picked from commit006355b)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 14, 2023
@bedevere-app
Copy link

GH-113137 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 14, 2023
…pythonGH-113116)(cherry picked from commit006355b)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 14, 2023
AlexWaygood added a commit that referenced this pull requestDec 14, 2023
GH-113116) (#113136)gh-101100: Fix Sphinx nitpicks in `library/collections.abc.rst` (GH-113116)(cherry picked from commit006355b)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull requestDec 14, 2023
GH-113116) (#113137)gh-101100: Fix Sphinx nitpicks in `library/collections.abc.rst` (GH-113116)(cherry picked from commit006355b)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rhettingerrhettingerrhettinger approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AlexWaygood@rhettinger
[8]ページ先頭
©2009-2025 Movatter.jp