Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-76785: Fixes for test.support.interpreters#112982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedDec 11, 2023•
edited by bedevere-appbot
Loading

This involves a number of changes for PEP 734.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Clang Installed 3.x has failed when building commit86a77f4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/531/builds/4959) and take a look at the build logs.
  4. Check if the failure is related to this commit (86a77f4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/531/builds/4959

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line178, in_runtest_env_changed_exc    _load_run_test(result, runtests)~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line125, in_load_run_test    test_mod= importlib.import_module(module_name)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/importlib/__init__.py", line88, inimport_modulereturn _bootstrap._gcd_import(name[level:], package, level)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"<frozen importlib._bootstrap>", line1387, in_gcd_import  File"<frozen importlib._bootstrap>", line1360, in_find_and_load  File"<frozen importlib._bootstrap>", line1331, in_find_and_load_unlocked  File"<frozen importlib._bootstrap>", line935, in_load_unlocked  File"<frozen importlib._bootstrap_external>", line1011, inexec_module  File"<frozen importlib._bootstrap>", line488, in_call_with_frames_removed  File"/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/test_threading.py", line30, in<module>from test.supportimport interpretersImportError:cannot import name 'interpreters' from 'test.support' (/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.13/test/support/__init__.py)

@ericsnowcurrently
Copy link
MemberAuthor

I have a fix for the buildbot failure ingh-113014.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Fedora Stable Clang Installed 3.x has failed when building commit86a77f4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/350/builds/5021) and take a look at the build logs.
  4. Check if the failure is related to this commit (86a77f4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/350/builds/5021

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line178, in_runtest_env_changed_exc    _load_run_test(result, runtests)~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line125, in_load_run_test    test_mod= importlib.import_module(module_name)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.13/importlib/__init__.py", line88, inimport_modulereturn _bootstrap._gcd_import(name[level:], package, level)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"<frozen importlib._bootstrap>", line1387, in_gcd_import  File"<frozen importlib._bootstrap>", line1360, in_find_and_load  File"<frozen importlib._bootstrap>", line1331, in_find_and_load_unlocked  File"<frozen importlib._bootstrap>", line935, in_load_unlocked  File"<frozen importlib._bootstrap_external>", line1011, inexec_module  File"<frozen importlib._bootstrap>", line488, in_call_with_frames_removed  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.13/test/test_threading.py", line30, in<module>from test.supportimport interpretersImportError:cannot import name 'interpreters' from 'test.support' (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.13/test/support/__init__.py)

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Clang Installed 3.x has failed when building commit86a77f4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/14/builds/5056) and take a look at the build logs.
  4. Check if the failure is related to this commit (86a77f4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/14/builds/5056

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line178, in_runtest_env_changed_exc    _load_run_test(result, runtests)~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line125, in_load_run_test    test_mod= importlib.import_module(module_name)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/importlib/__init__.py", line88, inimport_modulereturn _bootstrap._gcd_import(name[level:], package, level)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"<frozen importlib._bootstrap>", line1387, in_gcd_import  File"<frozen importlib._bootstrap>", line1360, in_find_and_load  File"<frozen importlib._bootstrap>", line1331, in_find_and_load_unlocked  File"<frozen importlib._bootstrap>", line935, in_load_unlocked  File"<frozen importlib._bootstrap_external>", line1011, inexec_module  File"<frozen importlib._bootstrap>", line488, in_call_with_frames_removed  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/test_threading.py", line30, in<module>from test.supportimport interpretersImportError:cannot import name 'interpreters' from 'test.support' (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/support/__init__.py)

ericsnowcurrently added a commit that referenced this pull requestDec 12, 2023
gh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed).  Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports.  This fixes that by catching ImportError in test_threading.py.
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE Fedora Stable Clang Installed 3.x has failed when building commit86a77f4.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/451/builds/3930) and take a look at the build logs.
  4. Check if the failure is related to this commit (86a77f4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/451/builds/3930

Failed tests:

  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line178, in_runtest_env_changed_exc    _load_run_test(result, runtests)~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.13/test/libregrtest/single.py", line125, in_load_run_test    test_mod= importlib.import_module(module_name)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.13/importlib/__init__.py", line88, inimport_modulereturn _bootstrap._gcd_import(name[level:], package, level)~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"<frozen importlib._bootstrap>", line1387, in_gcd_import  File"<frozen importlib._bootstrap>", line1360, in_find_and_load  File"<frozen importlib._bootstrap>", line1331, in_find_and_load_unlocked  File"<frozen importlib._bootstrap>", line935, in_load_unlocked  File"<frozen importlib._bootstrap_external>", line1011, inexec_module  File"<frozen importlib._bootstrap>", line488, in_call_with_frames_removed  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.13/test/test_threading.py", line30, in<module>from test.supportimport interpretersImportError:cannot import name 'interpreters' from 'test.support' (/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.13/test/support/__init__.py)

Comment on lines +156 to +164
Doc/**/*queue* @rhettinger
PCbuild/**/*queue* @rhettinger
Modules/_queuemodule.c @rhettinger
Lib/*queue*.py @rhettinger
Lib/asyncio/*queue*.py @rhettinger
Lib/multiprocessing/*queue*.py @rhettinger
Lib/test/*queue*.py @rhettinger
Lib/test_asyncio/*queue*.py @rhettinger
Lib/test_multiprocessing/*queue*.py @rhettinger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The last matching pattern inCODEOWNERS takes the precedence, so you can do:

**/*queue*                    @rhettingersupport/interpreters/queues.py  @ericsnowcurrently

to set@rhettinger as owner of all the*queue* files exceptsupport/interpreters/queues.py, which will be owned by@ericsnowcurrently instead.

Moving the subinterpreter section after the**/*queue* line should also override the owner forsupport/interpreters/queues.py without further changes.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thought there was something like that but I couldn't find it via web search. Thanks for explaining. I'll fix it in a follow-up PR.

ezio-melotti reacted with thumbs up emoji
ericsnowcurrently added a commit that referenced this pull requestDec 13, 2023
Ingh-112982 I made some changes to .github/CODEOWNERS.  Later,@ezio-melotti pointed out that some of those changes were unnecessary.
jeff5 added a commit to jeff5/cpython that referenced this pull requestDec 25, 2023
…GH-112982)This is so that we can run python -m test.test_interpreters. As such itbackports that aspect of commit86a77f4,where it is implemnented by a package __main__.py.
jeff5 added a commit to jeff5/cpython that referenced this pull requestDec 25, 2023
…GH-112982)This is so that we can run python -m test.test_interpreters. As such itbackports that aspect of commit86a77f4,where it is implemented by a package __main__.py.
@bedevere-app
Copy link

GH-113470 is a backport of this pull request to the3.12 branch.

serhiy-storchaka pushed a commit that referenced this pull requestDec 25, 2023
…H-113470)This is so that we can run python -m test.test_interpreters. As such itbackports that aspect of commit86a77f4,where it is implemented by a package __main__.py.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 25, 2023
…GH-112982) (pythonGH-113470)This is so that we can run python -m test.test_interpreters. As such itbackports that aspect of commit86a77f4,where it is implemented by a package __main__.py.(cherry picked from commitbdad5c3)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
serhiy-storchaka pushed a commit that referenced this pull requestDec 25, 2023
…H-113470) (GH-113473)This is so that we can run python -m test.test_interpreters. As such itbackports that aspect of commit86a77f4,where it is implemented by a package __main__.py.(cherry picked from commitbdad5c3)Co-authored-by: Jeff Allen <ja.py@farowl.co.uk>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…ongh-113014)pythongh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed).  Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports.  This fixes that by catching ImportError in test_threading.py.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Inpythongh-112982 I made some changes to .github/CODEOWNERS.  Later,@ezio-melotti pointed out that some of those changes were unnecessary.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…ongh-113014)pythongh-112982 broke test_threading on one of the s390 buildbots (Fedora Clang Installed).  Apparently ImportError is raised (rather than ModuleNotFoundError) for the name part of "from" imports.  This fixes that by catching ImportError in test_threading.py.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Inpythongh-112982 I made some changes to .github/CODEOWNERS.  Later,@ezio-melotti pointed out that some of those changes were unnecessary.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiezio-melotti left review comments

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericsnowcurrently@bedevere-bot@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp