Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-112898: warn about unsaved files when quitting IDLE on macOS#112939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Implement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE.
terryjreedy approved these changesDec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This fixes the bug on Catalina, which I now realize also has the bug. Please merge if you think ready or ask me to.
serhiy-storchaka approved these changesDec 11, 2023
Thanks@ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 11, 2023
…pythonGH-112939)*pythongh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE.(cherry picked from commit3251ba8)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Christopher Chavez chrischavez@gmx.us
GH-112960 is a backport of this pull request to the3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 11, 2023
…pythonGH-112939)*pythongh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE.(cherry picked from commit3251ba8)Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>Co-authored-by: Christopher Chavez chrischavez@gmx.us
GH-112961 is a backport of this pull request to the3.11 branch. |
ronaldoussoren added a commit that referenced this pull requestDec 11, 2023
GH-112939) (#112960)gh-112898: warn about unsaved files when quitting IDLE on macOS (GH-112939)*gh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE.(cherry picked from commit3251ba8)Co-authored-by: Christopher Chavez chrischavez@gmx.usCo-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this pull requestDec 11, 2023
GH-112939) (#112961)gh-112898: warn about unsaved files when quitting IDLE on macOS (GH-112939)*gh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE.(cherry picked from commit3251ba8)Co-authored-by: Christopher Chavez chrischavez@gmx.usCo-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…python#112939)*pythongh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE. Co-authored-by: Christopher Chavez chrischavez@gmx.us
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…python#112939)*pythongh-112898: warn about unsaved files when quitting IDLE on macOSImplement the TK function ``::tk::mac::Quit`` on macOS toensure that IDLE asks about saving unsaved files whenquitting IDLE. Co-authored-by: Christopher Chavez chrischavez@gmx.us
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implement the TK function
::tk::mac::Quiton macOS to ensure that IDLE asks about saving unsaved files when quitting IDLE.Co-authored-by: Christopher Chavezchrischavez@gmx.us