Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-112795: Allow/ folder in a zipfile#112932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
/ folder in a zipfile/ folder in a zipfileUh oh!
There was an error while loading.Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools.(cherry picked from commit541c5db)Co-authored-by: AN Long <aisk@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>
GH-113789 is a backport of this pull request to the3.12 branch. |
gh-112795: Allow `/` folder in a zipfile (GH-112932)Allow extraction (no-op) of a "/" folder in a zipfile, they are commonly added by some archive creation tools.(cherry picked from commit541c5db)Co-authored-by: AN Long <aisk@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Gregory P. Smith <greg@krypto.org>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks for the view! The buildbot failed and complains |
someone has subscribed apple support to the email address for this issue? i'm locking it for a while. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This behavior is introduced in#98346 (comment), but as#112795 shows, some tools such as jira or self structeded tools do have
/in the file lists in the created zip file. And modern unzip tools support them, so I think we should revert the change.If this PR can be accepted, it should be backported to 3.12.