Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix Sphinx warning in library/http.cookies.rst#112908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedDec 9, 2023•
edited
Loading

Fix these warnings:

❯SPHINXERRORHANDLING=-n PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -j auto -n. build/html library/http.cookies.rst2>&1| grep WARNING| tee>(wc -l)Doc/library/http.cookies.rst:57: WARNING: py:meth reference target not found: value_decodeDoc/library/http.cookies.rst:57: WARNING: py:meth reference target not found: value_encodeDoc/library/http.cookies.rst:144: WARNING: py:attr reference target not found: httponlyDoc/library/http.cookies.rst:148: WARNING: py:attr reference target not found: samesiteDoc/library/http.cookies.rst:155: WARNING: py:meth reference target not found: Morsel.__eq__Doc/library/http.cookies.rst:164: WARNING: py:attr reference target not found: samesite       6

Plus refer to MSIE 3.0x in the past tense (EOL since something like 2003! Should we even remove that bit?), make cookie lowercase, adjust some formatting.

📚 Documentation preview 📚:https://cpython-previews--112908.org.readthedocs.build/en/112908/library/http.cookies.html

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great overall! A few small suggestions:

hugovk reacted with hooray emoji
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🍪🎉

hugovk reacted with laugh emoji
@hugovkhugovk merged commit7595d47 intopython:mainDec 10, 2023
@hugovkhugovk deleted the docs-fix-sphinx-warnings-http.cookies branchDecember 10, 2023 12:53
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

GH-112929 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 10, 2023
@bedevere-app
Copy link

GH-112930 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 10, 2023
…onGH-112908)(cherry picked from commit7595d47)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 10, 2023
…onGH-112908)(cherry picked from commit7595d47)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk added a commit that referenced this pull requestDec 10, 2023
…112908) (#112929)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Fix Sphinx warning in library/http.cookies.rst (GH-112908)
hugovk added a commit that referenced this pull requestDec 10, 2023
…112908) (#112930)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Fix Sphinx warning in library/http.cookies.rst (GH-112908)
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp