Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-112800: Ignore PermissionError on SubprocessTransport.close()#112803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedDec 6, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
3eae8fb to9f1b302CompareIn case the spawned process is setuid, we may not be able to sendsignals to it, in which case our .kill() call will raisePermissionError.Ignore that in order to avoid .close() raising an exception. Hopefullythe process will exit as a result of receiving EOF on its stdin.
9f1b302 tof79b680CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey! Sorry for the delay. This makes sense. I was going to ask for a test, but of course that's pointless since we're not going to be writing tests that depend on setuid programs. The fix is really minimal, so I'm going to merge this.
Do you have an opinion on whether this is important enough to backport the fix to 3.12 or 3.11?
…) in asyncio (python#112803)In case the spawned process is setuid, we may not be able to sendsignals to it, in which case our .kill() call will raisePermissionError.Ignore that in order to avoid .close() raising an exception. Hopefullythe process will exit as a result of receiving EOF on its stdin.
…) in asyncio (python#112803)In case the spawned process is setuid, we may not be able to sendsignals to it, in which case our .kill() call will raisePermissionError.Ignore that in order to avoid .close() raising an exception. Hopefullythe process will exit as a result of receiving EOF on its stdin.
…) in asyncio (python#112803)In case the spawned process is setuid, we may not be able to sendsignals to it, in which case our .kill() call will raisePermissionError.Ignore that in order to avoid .close() raising an exception. Hopefullythe process will exit as a result of receiving EOF on its stdin.
…) in asyncio (python#112803)In case the spawned process is setuid, we may not be able to sendsignals to it, in which case our .kill() call will raisePermissionError.Ignore that in order to avoid .close() raising an exception. Hopefullythe process will exit as a result of receiving EOF on its stdin.
Uh oh!
There was an error while loading.Please reload this page.
In case the spawned process is setuid, we may not be able to send signals to it, in which case our .kill() call will raise PermissionError.
Ignore that in order to avoid .close() raising an exception. Hopefully the process will exit as a result of receiving EOF on its stdin.
Closes#112800