Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-112769: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffix#112771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 1 commit intopython:mainfromhroncok:zlib-ng-version
Dec 5, 2023

Conversation

@hroncok
Copy link
Contributor

@hroncokhroncok commentedDec 5, 2023•
edited by bedevere-appbot
Loading

zlib-ng defines the version as "1.3.0.zlib-ng".

https://github.com/zlib-ng/zlib-ng/blob/f3211aba349a1d4781d0d41cb00d29fb8325af06/zlib.h.in#L61

test.test_zlib.CompressObjectTestCase.test_flushes blew up with:

Traceback (most recent call last):  File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in test_flushes    ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.'))          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in <genexpr>    ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.'))                ^^^^^^ValueError: invalid literal for int() with base 10: 'zlib-ng'

This reuses logic from another test.

Fixes#112769

…th non-int suffixzlib-ng defines the version as "1.3.0.zlib-ng".https://github.com/zlib-ng/zlib-ng/blob/f3211aba349a1d4781d0d41cb00d29fb8325af06/zlib.h.in#L61test.test_zlib.CompressObjectTestCase.test_flushes blew up with:    Traceback (most recent call last):      File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in test_flushes        ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.'))              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^      File "/builddir/build/BUILD/Python-3.12.0/Lib/test/test_zlib.py", line 477, in <genexpr>        ver = tuple(int(v) for v in zlib.ZLIB_RUNTIME_VERSION.split('.'))                    ^^^^^^    ValueError: invalid literal for int() with base 10: 'zlib-ng'This reuses logic from another test.Fixespython#112769
@miss-islington-app
Copy link

Thanks@hroncok for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

hroncok reacted with thumbs up emoji

@bedevere-app
Copy link

GH-112773 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 5, 2023
…th non-int suffix (pythonGH-112771)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 5, 2023
@bedevere-app
Copy link

GH-112774 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 5, 2023
…th non-int suffix (pythonGH-112771)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 5, 2023
@hroncokhroncok deleted the zlib-ng-version branchDecember 5, 2023 19:40
@hroncok
Copy link
ContributorAuthor

Thanks@serhiy-storchaka

serhiy-storchaka pushed a commit that referenced this pull requestDec 5, 2023
…ith non-int suffix (GH-112771) (GH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok <miro@hroncok.cz>
serhiy-storchaka pushed a commit that referenced this pull requestDec 5, 2023
…ith non-int suffix (GH-112771) (GH-112773)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok <miro@hroncok.cz>
befeleme pushed a commit to fedora-python/cpython that referenced this pull requestJan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
befeleme pushed a commit to fedora-python/cpython that referenced this pull requestJan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok <miro@hroncok.cz>
befeleme pushed a commit to fedora-python/cpython that referenced this pull requestJan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
befeleme pushed a commit to fedora-python/cpython that referenced this pull requestJan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
befeleme pushed a commit to fedora-python/cpython that referenced this pull requestJan 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…th non-int suffix (pythonGH-112771)zlib-ng defines the version as "1.3.0.zlib-ng".
stratakis pushed a commit to stratakis/cpython that referenced this pull requestFeb 27, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hroncok added a commit to fedora-python/cpython that referenced this pull requestMar 7, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 11, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 11, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 20, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
stratakis pushed a commit to stratakis/cpython that referenced this pull requestMar 25, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hroncok added a commit to fedora-python/cpython that referenced this pull requestMar 26, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull requestApr 2, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
@encukouencukou added 3.10only security fixes needs backport to 3.10only security fixes and removed 3.10only security fixes labelsMay 21, 2024
@miss-islington-app
Copy link

Thanks@hroncok for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hroncok and@serhiy-storchaka, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker d384813ff18b33280a90b6d2011654528a2b6ad1 3.10

@bedevere-app
Copy link

GH-119565 is a backport of this pull request to the3.10 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelMay 25, 2024
@bedevere-app
Copy link

GH-119566 is a backport of this pull request to the3.9 branch.

@bedevere-app
Copy link

GH-119567 is a backport of this pull request to the3.8 branch.

pablogsal pushed a commit that referenced this pull requestMay 28, 2024
…E_VERSION with non-int suffix (GH-112771) (#119565)[3.10]gh-112769: test_zlib: test_zlib: Fix comparison of ZLIB_RUNTIME_VERSION with non-int suffixzlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok miro@hroncok.cz
ambv pushed a commit that referenced this pull requestMay 30, 2024
…_VERSION with non-int suffix (GH-112771) (GH-119566)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok miro@hroncok.cz
ambv pushed a commit that referenced this pull requestMay 30, 2024
…_VERSION with non-int suffix (GH-112771) (GH-119567)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)Co-authored-by: Miro Hrončok miro@hroncok.cz
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…th non-int suffix (pythonGH-112771)zlib-ng defines the version as "1.3.0.zlib-ng".
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestSep 9, 2024
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hrnciar pushed a commit to fedora-python/cpython that referenced this pull requestApr 23, 2025
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
hroncok added a commit to fedora-python/cpython that referenced this pull requestJul 4, 2025
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull requestAug 12, 2025
…SION with non-int suffix (pythonGH-112771) (pythonGH-112774)zlib-ng defines the version as "1.3.0.zlib-ng".(cherry picked from commitd384813)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Labels

testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test.test_zlib.CompressObjectTestCase.test_flushes fails to parse ZLIB_VERSION with zlib-ng

3 participants

@hroncok@serhiy-storchaka@encukou
[8]ページ先頭
©2009-2025 Movatter.jp