Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-109311: Remove support for non-complex/float types in __complex/float__#112680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
skirpichev wants to merge13 commits intopython:main
base:main
Choose a base branch
Loading
fromskirpichev:109311-remove-ss-in-float-complex-dunders

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedDec 4, 2023•
edited by bedevere-appbot
Loading

@skirpichev
Copy link
ContributorAuthor

CC@vstinner maybe it's time, after 6 releases?

@vstinner
Copy link
Member

I would prefer to wait for Python 3.15 alpha 1. IMO changing the behavior in Python 3.14 beta 1 is too late.

@skirpichev
Copy link
ContributorAuthor

CC@vstinner
CC@picnixz

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please update:

  • Doc/whatsnew/3.15.rst: the C API removal section
  • Maybe aversionchanged entry underobject.__complex__ andobject.__float__.
  • In a follow-up PR, let's also update "c-api-pending-removal-in-315" to notify this change in 3.13 & 3.14 (still, make a PR against main)

skirpichev reacted with thumbs up emoji
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

I think you need to regenerate the NEWS entry as it's in an "old" folder

@skirpichev
Copy link
ContributorAuthor

Doc/whatsnew/3.15.rst: the C API removal section

Are you sure it should be here? Strictly speaking, this affects not just C extensions.

So far, this placed in "Others" subsection of "Removed" section.

Maybe a versionchanged entry under object.complex and object.float.

Docs already says: Should return a value of the appropriate type.

I think you need to regenerate the NEWS entry as it's in an "old" folder

In most (all?) cases you could just move news entry.

@picnixz
Copy link
Member

picnixz commentedMay 11, 2025•
edited
Loading

Are you sure it should be here? Strictly speaking, this affects not just C extensions.

Ah yes, my bad. Make it under thebuiltins module then maybe or "Others" as you suggested, up to you

Docs already says: Should return a value of the appropriate type.

Oh ok. No need for an additional note then.

@skirpichevskirpichev requested a review frompicnixzMay 11, 2025 11:29
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The "pending-future-removal" document would still contain the deprecation notice so let's move it to 3.15.rst in a follow-up PR (or in this one, up to you). Since it's in "future removal", I don't know if we actually need a second round of discussion to decide on the version.

In the docs it says "should return", maybe we should be more precise and make it a "must return a float/complex". While users would see a DeprecationWarning, it's better for new online docs to state that we only want exact float/complex.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@skirpichevskirpichev requested a review frompicnixzMay 11, 2025 13:39
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I would like to hear@serhiy-storchaka on this issue, he wrote similar changes for other types.

@serhiy-storchaka
Copy link
Member

I have a completely opposite opinion. I will try to start a new discussion soon.

vstinner reacted with eyes emoji

@vstinner
Copy link
Member

I have a completely opposite opinion. I will try to start a new discussion soon.

Any update@serhiy-storchaka?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@picnixzpicnixzAwaiting requested review from picnixz

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@skirpichev@vstinner@picnixz@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp