Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix Sphinx warning inlibrary/gettext.rst#112668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedDec 3, 2023•
edited by github-actionsbot
Loading

Most of these underscore-prefixed are described as "protected", I don't think they need documenting individually, so added!.

Also fix RedHat -> Red Hat typo.

❯SPHINXERRORHANDLING=-n PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -j auto -n. build/html library/gettext.rst2>&1| grep WARNING| tee>(wc -l)Doc/library/gettext.rst:260: WARNING: py:attr reference target not found: _infoDoc/library/gettext.rst:299: WARNING: py:meth reference target not found: _parseDoc/library/gettext.rst:304: WARNING: py:attr reference target not found: _charsetDoc/library/gettext.rst:317: WARNING: py:attr reference target not found: _info       4

📚 Documentation preview 📚:https://cpython-previews--112668.org.readthedocs.build/

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Possibly we could also reduce other references to "protected" private attributes, but the others seem less clear-cut, and I'm not an expert ingettext (maybe it's important that users know about them!), so I'm okay leaving them as they are 👍

hugovk reacted with thumbs up emoji
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, pet peeve: no need to link to the module we're already in :)

hugovk reacted with thumbs up emoji
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@hugovkhugovkenabled auto-merge (squash)December 3, 2023 20:16
@hugovkhugovk merged commit489aeac intopython:mainDec 3, 2023
@hugovkhugovk deleted the docs-fix-sphinx-warnings-gettext branchDecember 3, 2023 20:23
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 489aeac3a2d3b347ff033334688e2f44eec7944a 3.12

@bedevere-app
Copy link

GH-112673 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 3, 2023
…H-112668)(cherry picked from commit489aeac)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 3, 2023
@bedevere-app
Copy link

GH-112674 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelDec 3, 2023
hugovk added a commit to hugovk/cpython that referenced this pull requestDec 3, 2023
…ythonGH-112668)(cherry picked from commit489aeac)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull requestDec 3, 2023
) (#112673)gh-101100: Fix Sphinx warning in `library/gettext.rst` (GH-112668)(cherry picked from commit489aeac)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
hugovk added a commit that referenced this pull requestDec 3, 2023
) (#112674)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…112668)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…112668)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp