Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-112660: Do not clear arbitrary errors on import#112661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedDec 3, 2023
edited by bedevere-appbot
Loading

Previously arbitrary errors could be cleared during formatting error messages for ImportError or AttributeError for modules. Now all unexpected errors are reported.

Previously arbitrary errors could be cleared during formatting errormessages for ImportError or AttributeError for modules. Now allunexpected errors are reported.
@serhiy-storchakaserhiy-storchaka merged commit8660fb7 intopython:mainDec 7, 2023
@serhiy-storchakaserhiy-storchaka deleted the import-no-clear-error branchDecember 7, 2023 10:19
ericsnowcurrently added a commit that referenced this pull requestDec 7, 2023
gh-112853)As ofgh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown().  This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()).  They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New".This also forward-ports the "What's New" entry from 3.12 (gh-112850).  Note that we do not also forward-port the fix in that PR.  The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…2661)Previously arbitrary errors could be cleared during formatting errormessages for ImportError or AttributeError for modules. Now allunexpected errors are reported.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…rpreter (pythongh-112853)As ofpythongh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown().  This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()).  They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New".This also forward-ports the "What's New" entry from 3.12 (pythongh-112850).  Note that we do not also forward-port the fix in that PR.  The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…2661)Previously arbitrary errors could be cleared during formatting errormessages for ImportError or AttributeError for modules. Now allunexpected errors are reported.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…rpreter (pythongh-112853)As ofpythongh-112661, the threading module expects the _thread module to have a _is_main_interpreter(), which is used in the internal threading._shutdown().  This change causes a problem for anyone that replaces the _thread module with a custom one (only if they don't provide _is_main_interpreter()).  They need to be sure to add it for 3.13+, thus this PR is adding a note in "What's New".This also forward-ports the "What's New" entry from 3.12 (pythongh-112850).  Note that we do not also forward-port the fix in that PR.  The fix is there only due to a regression from 3.12.0. There is no regression in 3.13+.
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull requestDec 17, 2024
…moduleI missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
hauntsaninja added a commit that referenced this pull requestDec 20, 2024
…#128047)I missed the extra `PyModule_Check` in#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced in#112661.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 20, 2024
…module (pythonGH-128047)I missed the extra `PyModule_Check` inpythonGH-127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpythonGH-112661.(cherry picked from commit45e6dd6)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja added a commit that referenced this pull requestDec 20, 2024
…-module (GH-128047) (#128114)gh-128030: Avoid error from PyModule_GetFilenameObject for non-module (GH-128047)I missed the extra `PyModule_Check` inGH-127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inGH-112661.(cherry picked from commit45e6dd6)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestDec 23, 2024
…module (python#128047)I missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull requestJan 8, 2025
…module (python#128047)I missed the extra `PyModule_Check` inpython#127660 because I was looking at3.12 as the base implementation for import from. This meant that Imissed the `PyModuleCheck` introduced inpython#112661.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnerAwaiting requested review from vstinner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp