Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-110190: Fix ctypes structs with array on Arm#112604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 6 commits intopython:mainfromdiegorusso:main
Dec 5, 2023

Conversation

@diegorusso
Copy link
Contributor

@diegorussodiegorusso commentedDec 1, 2023•
edited
Loading

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.
This because on Arm platforms structs with at most 4 elements of any
floating point type values can be passed through registers. If the type
is double the maximum size of the struct is 32 bytes.
By Arm platforms it is meant 32 and 64 bit.
On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.

Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.
@ghost
Copy link

ghost commentedDec 1, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@ambvambv added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 1, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ambv for commit34f9c99 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelDec 1, 2023
@ambvambv merged commitbc68f4a intopython:mainDec 5, 2023
@ambv
Copy link
Contributor

ambv commentedDec 5, 2023

Thanks, Diego! ✨ 🍰 ✨

diegorusso reacted with heart emoji

@ambvambv added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsDec 5, 2023
@miss-islington-app
Copy link

Thanks@diegorusso for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@diegorusso for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@diegorusso and@ambv, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker bc68f4a4abcfbea60bb1db1ccadb07613561931c 3.11

@miss-islington-app
Copy link

Sorry,@diegorusso and@ambv, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker bc68f4a4abcfbea60bb1db1ccadb07613561931c 3.12

diegorusso added a commit to diegorusso/cpython that referenced this pull requestDec 5, 2023
…112604)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)
@bedevere-app
Copy link

GH-112766 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 5, 2023
diegorusso added a commit to diegorusso/cpython that referenced this pull requestDec 5, 2023
…112604)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)
@diegorusso
Copy link
ContributorAuthor

@sunmy2019 This is an old document. The right version ishttps://files.openpower.foundation/s/cfA2oFPXbbZwEBK. Read my comment here:#110190 (comment)

sunmy2019 reacted with thumbs up emojisunmy2019 reacted with heart emoji

ambv added a commit that referenced this pull requestDec 8, 2023
diegorusso added a commit to diegorusso/cpython that referenced this pull requestDec 11, 2023
Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.
@diegorusso
Copy link
ContributorAuthor

@sunmy2019 and@Yhg1s the issue on PPC64LE has been fixed with#112959

sunmy2019 reacted with thumbs up emoji

ambv pushed a commit that referenced this pull requestDec 13, 2023
Fix the same issue of PR#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.
diegorusso added a commit to diegorusso/cpython that referenced this pull requestDec 15, 2023
…honGH-112959)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310
diegorusso added a commit to diegorusso/cpython that referenced this pull requestDec 15, 2023
…honGH-112959)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I31730a3ebe558570ce1d7a3b26db8392f18d1770
ambv pushed a commit that referenced this pull requestJan 5, 2024
#113167)Fix the same issue of PR#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310
ambv pushed a commit that referenced this pull requestJan 5, 2024
#113170)Fix the same issue of PR#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I31730a3ebe558570ce1d7a3b26db8392f18d1770
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…12959)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…12959)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…112604) (python#112766)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830)(cherry picked from commit9f67042)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…honGH-112959) (python#113167)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…112604) (python#112766)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830)(cherry picked from commit9f67042)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…honGH-112959) (python#113167)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…112604) (python#112766)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830)(cherry picked from commit9f67042)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestSep 19, 2024
…honGH-112959) (python#113167)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestJul 30, 2025
…112604) (python#112766)Set MAX_STRUCT_SIZE to 32 in stgdict.c when on Arm platforms.This because on Arm platforms structs with at most 4 elements of anyfloating point type values can be passed through registers. If the typeis double the maximum size of the struct is 32 bytes.On x86-64 Linux, it's maximum 16 bytes hence we need to differentiate.(cherry picked from commitbc68f4a)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestJul 30, 2025
…ngh-112604 on PPC64LE (pythonGH-112818) (python#112830)(cherry picked from commit9f67042)Signed-off-by: Michał Górny <mgorny@gentoo.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestJul 30, 2025
…honGH-112959) (python#113167)Fix the same issue of PRpython#112604 on PPC64LE platformRefactor tests to make easier to add more platfroms if needed.(cherry picked from commit6644ca4)Change-Id: I1ada30808c0d593a43eca3fa7a628c26bc276310Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ambvambvambv approved these changes

Assignees

@ambvambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@diegorusso@bedevere-bot@ambv@Yhg1s@sunmy2019
[8]ページ先頭
©2009-2025 Movatter.jp