Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-112125: Fix None.__ne__(None) returning NotImplemented instead of False#112504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedNov 28, 2023 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
e15fb81 to18d5a40CompareMost changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
18d5a40 to5a5ce2cCompareMost changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you mind to add a test and add a Changelog (NEWS) entry? Seehttps://devguide.python.org/ on how to add a Changelog entry.
237be2c to1bb1748CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
1bb1748 to6a31b1dCompareThanks@andrewluotechnologies for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry,@andrewluotechnologies and@vstinner, I could not cleanly backport this to |
…ad of False (python#112504)(cherry picked from commit9c3458e)
GH-112827 is a backport of this pull request to the3.12 branch. |
Merged, thank you. I backported the change manually to 3.12 to fix a merge conflict. |
Uh oh!
There was an error while loading.Please reload this page.
I tested this fix on Windows 11 with VS2022. Compiled and ran
None.__ne__(None)before and after my changes. Result before:NotImplemented, after:FalseNote: this is my first pull request/contributing and this code wasn't my original idea - thanks to@rhettinger for suggesting the route to fix this. I only implemented the code.