Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-112414: Add additional unit tests for callingrepr() on a namespace package#112475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 5 commits intopython:mainfromAlexWaygood:more-module-repr-tests
Nov 28, 2023

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commentedNov 27, 2023•
edited by bedevere-appbot
Loading

Addressing@ericsnowcurrently's post-merge review at#112425 (comment). I've verified locally that the second test here fails if you build CPython withe954ac7 (the commit prior to0622839).

@ericsnowcurrently, would you also like me to remove the test I added in0622839, or is that okay to stay? :)

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently, would you also like me to remove the test I added in0622839, or is that okay to stay? :)

Removingthat test makes sense, since the test you add here covers that bit and the former is a bit out of place.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly LGTM

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, s/"/'/g

AlexWaygoodand others added3 commitsNovember 27, 2023 23:49
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
…rilyCo-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@AlexWaygood
Copy link
MemberAuthor

Thanks! I have made the requested changes; please review again

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

AlexWaygood reacted with rocket emoji
@AlexWaygoodAlexWaygood deleted the more-module-repr-tests branchNovember 28, 2023 00:10
@miss-islington-app
Copy link

Thanks@AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 28, 2023
…namespace package (pythonGH-112475)(cherry picked from commitcf20540)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

GH-112480 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 28, 2023
@ericsnowcurrently
Copy link
Member

Thanks for working on this,@AlexWaygood!

AlexWaygood reacted with heart emoji

@AlexWaygood
Copy link
MemberAuthor

You're very welcome! :D

AlexWaygood added a commit that referenced this pull requestNov 28, 2023
… namespace package (GH-112475) (#112480)gh-112414: Add additional unit tests for calling `repr()` on a namespace package (GH-112475)(cherry picked from commitcf20540)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…namespace package (python#112475)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…namespace package (python#112475)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-importlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood@ericsnowcurrently
[8]ページ先頭
©2009-2025 Movatter.jp