NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

iritkatriel merged 5 commits intopython:mainfromiritkatriel:gh-99606

Nov 26, 2023

Merged

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

iritkatriel merged 5 commits intopython:mainfromiritkatriel:gh-99606

Nov 26, 2023

Conversation

Copy link

Member

iritkatriel commentedNov 25, 2023•
edited by bedevere-appbot
Loading

Fixes#99606.

Issue:Bytecode for empty f-string != bytecode for empty normal string #99606

pythongh-99606: Make code generated for an empty f-string identical t…

cc370d7

…o that of a normal empty string

iritkatriel requested review frombrettcannon,ericsnowcurrently,markshannon,ncoghlan andwarsaw ascode owners

November 25, 2023 20:46

bedevere-appbot added the awaiting core review label

Nov 25, 2023

bedevere-appbot mentioned this pull request

Nov 25, 2023

Bytecode for empty f-string != bytecode for empty normal string#99606

Closed

iritkatriel requested review fromericvsmith and removed request forbrettcannon,ericsnowcurrently,markshannon,ncoghlan andwarsaw

November 25, 2023 20:46

iritkatriel commented

Nov 25, 2023

View reviewed changes

Lib/importlib/_bootstrap_external.py OutdatedShow resolvedHide resolved

fix magic number

8e15f08

ericvsmith approved these changes

Nov 26, 2023

View reviewed changes

Copy link

Member

ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure why the magic number needs to increase, because this is a backwards compatible change, but I suppose it doesn't really matter.

In any event, this looks good to me. Thanks!

bedevere-appbot added awaiting merge and removed awaiting core review labels

Nov 26, 2023

Merge branch 'main' intopythongh-99606

c1924e4

iritkatriel commented

Nov 26, 2023

View reviewed changes

Lib/importlib/_bootstrap_external.py OutdatedShow resolvedHide resolved

iritkatriel added2 commits

November 26, 2023 16:16

Update _bootstrap_external.py

21eedf4

Update _bootstrap_external.py

c5c1d96

iritkatriel merged commitfb202af intopython:main

Nov 26, 2023

bedevere-appbot removed the awaiting merge label

Nov 26, 2023

thatbirdguythatuknownot mentioned this pull request

Dec 19, 2023

gh-99606: consistent empty f-string bytecode#99608

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024

pythongh-99606: Make code generated for an empty f-string identical t…

9b6fd48

…o that of a normal empty string (python#112407)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024

pythongh-99606: Make code generated for an empty f-string identical t…

9cfdb7d

…o that of a normal empty string (python#112407)

Labels

None yet

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

Uh oh!

Conversation

iritkatriel commentedNov 25, 2023•
edited by bedevere-appbot
Loading

Uh oh!

Uh oh!

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Movatterモバイル変換

Uh oh!

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

gh-99606: Make code generated for an empty f-string identical to that of a normal empty string#112407

Uh oh!

Conversation

iritkatriel commentedNov 25, 2023• edited by bedevere-appbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

iritkatriel commentedNov 25, 2023•
edited by bedevere-appbot
Loading