Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-112345: Let failed protocol subclasscheck show non-method members#112344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
317d18a Let failed protocol subclasscheck show non-method members
randolf-scholz100c309 📜🤖 Added by blurb_it.
blurb-it[bot]fd840b2 added test
randolf-scholzc70acc4 Update Lib/test/test_typing.py
randolf-scholz5db2670 use assertRaisesRegex
randolf-scholz71925d5 Update Lib/test/test_typing.py
randolf-scholz998b45e sort members, fixed unit test
randolf-scholz77e3a4a 📜🤖 Added by blurb_it.
blurb-it[bot]f2e3276 removed duplicate blurp
randolf-scholzbc40f84 Update Lib/typing.py
randolf-scholz62b6f71 Update Lib/test/test_typing.py
randolf-scholzFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
📜🤖 Added by blurb_it.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit100c309d3e3a3dc44074efd286af4fdb7bbd46ac
There are no files selected for viewing
2 changes: 2 additions & 0 deletionsMisc/NEWS.d/next/Library/2023-11-23-17-25-27.gh-issue-112345.FFApHx.rst
randolf-scholz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Improve error message when trying to call :func:`issubclass` against a :class:`typing.Protocol` that has non-method members. | ||
| Patch by Randolf Scholz. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.