Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-112345: Let failed protocol subclasscheck show non-method members#112344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
AlexWaygood left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, but please add a test and a NEWS entry. The NEWS entry can be very terse, e.g.:
Improve error message when trying to call :func:`issubclass`against a :class:`typing.Protocol` that has non-method members.Patch by Randolph Sholz.I created an issue for you to link your NEWS entry to.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
AlexWaygood commentedNov 24, 2023
Congrats on your first CPython contribution,@randolf-scholz! |
# Release 4.9.0 (December 9, 2023)This feature release adds `typing_extensions.ReadOnly`, as specifiedby PEP 705, and makes various other improvements, especially to`@typing_extensions.deprecated()`.There are no changes since 4.9.0rc1.# Release 4.9.0rc1 (November 29, 2023)- Add support for PEP 705, adding `typing_extensions.ReadOnly`. Patch by Jelle Zijlstra.- All parameters on `NewType.__call__` are now positional-only. This means that the signature of `typing_extensions.NewType.__call__` now exactly matches the signature of `typing.NewType.__call__`. Patch by Alex Waygood.- Fix bug with using `@deprecated` on a mixin class. Inheriting from a deprecated class now raises a `DeprecationWarning`. Patch by Jelle Zijlstra.- `@deprecated` now gives a better error message if you pass a non-`str` argument to the `msg` parameter. Patch by Alex Waygood.- `@deprecated` is now implemented as a class for better introspectability. Patch by Jelle Zijlstra.- Exclude `__match_args__` from `Protocol` members. Backport ofpython/cpython#110683 by Nikita Sobolev.- When creating a `typing_extensions.NamedTuple` class, ensure `__set_name__` is called on all objects that define `__set_name__` and exist in the values of the `NamedTuple` class's class dictionary. Patch by Alex Waygood, backportingpython/cpython#111876.- Improve the error message when trying to call `issubclass()` against a `Protocol` that has non-method members. Patch by Alex Waygood (backportingpython/cpython#112344, by Randolph Scholz).
…-method members (python#112344)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
…-method members (python#112344)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
See#112340 (comment)
Closes#112345
issubclass()against a Protocol that has non-method members #112345