Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-112345: Let failed protocol subclasscheck show non-method members#112344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 11 commits intopython:mainfromrandolf-scholz:protocol_error_mesage
Nov 24, 2023

Conversation

@randolf-scholz
Copy link
Contributor

@randolf-scholzrandolf-scholz commentedNov 23, 2023
edited by AlexWaygood
Loading

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@AlexWaygoodAlexWaygood changed the titleLet failed protocol subclasscheck show non-method membersgh-112345: Let failed protocol subclasscheck show non-method membersNov 23, 2023
Copy link
Member

@AlexWaygoodAlexWaygood left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but please add a test and a NEWS entry. The NEWS entry can be very terse, e.g.:

Improve error message when trying to call :func:`issubclass`against a :class:`typing.Protocol` that has non-method members.Patch by Randolph Sholz.

I created an issue for you to link your NEWS entry to.

randolf-scholzand others added2 commitsNovember 23, 2023 19:01
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
randolf-scholzand others added2 commitsNovember 23, 2023 19:23
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
randolf-scholzand others added2 commitsNovember 24, 2023 10:27
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@AlexWaygood
Copy link
Member

Congrats on your first CPython contribution,@randolf-scholz!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull requestDec 11, 2023
# Release 4.9.0 (December 9, 2023)This feature release adds `typing_extensions.ReadOnly`, as specifiedby PEP 705, and makes various other improvements, especially to`@typing_extensions.deprecated()`.There are no changes since 4.9.0rc1.# Release 4.9.0rc1 (November 29, 2023)- Add support for PEP 705, adding `typing_extensions.ReadOnly`. Patch  by Jelle Zijlstra.- All parameters on `NewType.__call__` are now positional-only. This means that  the signature of `typing_extensions.NewType.__call__` now exactly matches the  signature of `typing.NewType.__call__`. Patch by Alex Waygood.- Fix bug with using `@deprecated` on a mixin class. Inheriting from a  deprecated class now raises a `DeprecationWarning`. Patch by Jelle Zijlstra.- `@deprecated` now gives a better error message if you pass a non-`str`  argument to the `msg` parameter. Patch by Alex Waygood.- `@deprecated` is now implemented as a class for better introspectability.  Patch by Jelle Zijlstra.- Exclude `__match_args__` from `Protocol` members.  Backport ofpython/cpython#110683 by Nikita Sobolev.- When creating a `typing_extensions.NamedTuple` class, ensure `__set_name__`  is called on all objects that define `__set_name__` and exist in the values  of the `NamedTuple` class's class dictionary. Patch by Alex Waygood,  backportingpython/cpython#111876.- Improve the error message when trying to call `issubclass()` against a  `Protocol` that has non-method members. Patch by Alex Waygood (backportingpython/cpython#112344, by Randolph Scholz).
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…-method members (python#112344)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…-method members (python#112344)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve error message when trying to callissubclass() against a Protocol that has non-method members

3 participants

@randolf-scholz@AlexWaygood@JelleZijlstra

[8]ページ先頭

©2009-2025 Movatter.jp