Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-65920: Implementsocket.sendfile withTransmitFile on Windows#112337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aisk wants to merge11 commits intopython:main
base:main
Choose a base branch
Loading
fromaisk:windows-socket-sendfile

Conversation

aisk
Copy link
Contributor

@aiskaisk commentedNov 23, 2023•
edited
Loading

  • Using theOverlapped.TransmitFile in_overlapped module to implementsocket.sendfile;
  • AddOverlapped.getresultex to implement the timeout functionality, which have almost the same codes as existsOverlapped.getresult, just with diffenernt arguments. I split theOverlapped.getresult in to another function to share the codes.

And some thought onos.sendfile:#102898 (comment)

@aiskaisk changed the titlegh-65920: Windows socket sendfilegh-65920: imlement socket.sendfile with TransmitFile on WindowsNov 23, 2023
@erlend-aaslanderlend-aasland changed the titlegh-65920: imlement socket.sendfile with TransmitFile on Windowsgh-65920: Implementsocket.sendfile withTransmitFile on WindowsJan 6, 2024
…WsHN.rstCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aisk
Copy link
ContributorAuthor

Hi@eryksun , sorry to bother you, but can you help me review this PR when you have time? Thanks very much!

@Archmonger
Copy link

Bumping this PR.

The community (and myself)seem to feel it is very disjointed thatsendfile support exists on *nix but not Windows, despite the plumbing already existing since Python 3.7.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@eryksuneryksunAwaiting requested review from eryksun

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aisk@Archmonger@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp