Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111786: Use separate opcode vars for Tier 1 and Tier 2#112289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 2 commits intopython:mainfrommdboom:alternative-workaround
Nov 20, 2023

Conversation

@mdboom
Copy link
Contributor

@mdboommdboom commentedNov 20, 2023•
edited by bedevere-appbot
Loading

Suggested by@neonene:#111786 (comment)

This makes Windows about 3% faster on pyperformance benchmarks. Seeanalysis here

neonene reacted with heart emoji
This makes Windows about 3% faster on pyperformance benchmarks.
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, looks very straightforward.

Though based on our offline conversation, did you find out whether Windows PGO uses-E?

Comment on lines 692 to 693
uint8_t opcode; /* Current opcode */
int oparg;/* Current opcode argument, if any */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heh, I would have kept the comments at the same column, so you don't appear to be editing theoparg line. :-)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure -- I think my editor did something magical.

@mdboom
Copy link
ContributorAuthor

mdboom commentedNov 20, 2023•
edited
Loading

Though based on our offline conversation, did you find out whether Windows PGO uses -E?

I don't know, but I think that's orthogonal to this. Currently on the benchmarking infrastructure, we only pass thePYTHON_UOPS env variable to pyperformance, so it definitely has no effect during build. Independently of this, I measured what happens when you force Tier 2 on during the build, and it is about 1% faster.

@gvanrossum
Copy link
Member

Though based on our offline conversation, did you find out whether Windows PGO uses -E?

I don't know, but I think that's orthogonal to this. Currently on the benchmarking infrastructure, we don't pass thePYTHON_UOPS env variable to pyperformance, so it definitely has no effect during build.

Ah, sorry. Should I merge this then?

Independently of this, I measured what happens when you force Tier 2 on during the build, and it is about 1% faster.

1% faster than without Tier 2, or 1% faster than main?

@mdboom
Copy link
ContributorAuthor

Though based on our offline conversation, did you find out whether Windows PGO uses -E?

I don't know, but I think that's orthogonal to this. Currently on the benchmarking infrastructure, we don't pass thePYTHON_UOPS env variable to pyperformance, so it definitely has no effect during build.

Ah, sorry. Should I merge this then?

Yeah, I think that's fine.

Independently of this, I measured what happens when you force Tier 2 on during the build, and it is about 1% faster.

1% faster than without Tier 2, or 1% faster than main?

When you turn Tier 2 on during build (PGO collection), it's 1% faster than if you don't. (Using Tier 2 at runtime in both cases).

@gvanrossum
Copy link
Member

When you turn Tier 2 on during build (PGO collection), it's 1% faster than if you don't. (Using Tier 2 at runtime in both cases).

That's great news!

@gvanrossumgvanrossum merged commit6a00a58 intopython:mainNov 20, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…on#112289)This makes Windows about 3% faster on pyperformance benchmarks.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…on#112289)This makes Windows about 3% faster on pyperformance benchmarks.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom@gvanrossum
[8]ページ先頭
©2009-2026 Movatter.jp