Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-108901: Deprecateinspect.getcallargs and slate it for removal#112236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sobolevn wants to merge6 commits intopython:main
base:main
Choose a base branch
Loading
fromsobolevn:issue-108901-getcallargs

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedNov 18, 2023•
edited by github-actionsbot
Loading

Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.

📚 Documentation preview 📚:https://cpython-previews--112236.org.readthedocs.build/

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn
Copy link
MemberAuthor

@terryjreedy thank you!

@terryjreedy
Copy link
Member

terryjreedy commentedNov 18, 2023•
edited
Loading

The added codelooks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

phrasing nits in the news and whatnew entries

Co-authored-by: Itamar Oren <itamarost@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@AlexWaygood
Copy link
Member

Ah, I see@hugovk asked for some changes in#108901 (comment) -- I'll hold off merging for now :)

@Wulian233
Copy link
Contributor

I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14

@vstinner
Copy link
Member

@sobolevn: What's the status of your PR?

@sobolevn
Copy link
MemberAuthor

I guess that I will have to start everything over in 3.15 :)

vstinner reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@itamaroitamaroitamaro left review comments

@terryjreedyterryjreedyterryjreedy left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

@vstinnervstinnerAwaiting requested review from vstinner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sobolevn@terryjreedy@AlexWaygood@Wulian233@vstinner@itamaro
[8]ページ先頭
©2009-2025 Movatter.jp