Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-108724: Use _PyTime_GetMonotonicClock() in parking_lot.c#112222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Using a system clock causes issues when it's being updated by thesystem administrator, NTP, Daylight Saving Time, or anythingelse. Sadly, on Windows, the monotonic clock resolution is around15.6 ms.Example:python#85876
@colesbury@ericsnowcurrently: Please don't use the system clock for locks. It causes too many issues. Using a monotonic clock is more reliable. Sadly, on Windows, the monotonic clock has a resolution of 15.6 ms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should use the monotonic clock when available, but this change isn't sufficient:
sem_timedwaitdoes not work with CLOCK_MONOTONIC. (Needsem_clockwaitif available)pthread_cond_tneeds to be initialized with the right attribute
| _PyTime_t deadline = _PyTime_Add(_PyTime_GetMonotonicClock(), timeout); | ||
| _PyTime_AsTimespec(deadline, &ts); | ||
| err = sem_timedwait(&sema->platform_sem, &ts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe:
# ifdefHAVE_SEM_CLOCKWAIT_PyTime_tdeadline=_PyDeadline_Init(timeout);_PyTime_AsTimespec_clamp(deadline,&ts);err=sem_clockwait(&sema->platform_sem,CLOCK_MONOTONIC,&ts);# else_PyTime_tdeadline=_PyTime_Add(_PyTime_GetSystemClock(),timeout);_PyTime_AsTimespec_clamp(deadline,&ts);err=sem_timedwait(&sema->platform_sem,&ts);#endif
Oh. I made a mechanical change to avoid _PyTime_GetSystemClock(). I didn't see that timestamps are passed to existing functions such as pthread_cond_timedwait(). I mark my PR as a draft for now and will try to update it to address Sam's review |
I don't have time to fix my PR right now. I may try again later ;-) |
colesbury commentedDec 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I wrote it up as an issue so that I don't forget about this and in case someone else wants to tackle it first:#112606 |
Uh oh!
There was an error while loading.Please reload this page.
Using a system clock causes issues when it's being updated by the system administrator, NTP, Daylight Saving Time, or anything else. Sadly, on Windows, the monotonic clock resolution is around 15.6 ms.
Example:#85876