Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized#112196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

salty-horse
Copy link
Contributor

@salty-horsesalty-horse commentedNov 17, 2023•
edited by github-actionsbot
Loading

The documentation of the deprecation of typing aliases in 3.12 (#94309) was just the names of the aliases, without a description of what happens to them. This can cause confusion, even if it's in the "Deprecated" section of documentation, since all other items include this description.

This should be backported to 3.12.

📚 Documentation preview 📚:https://cpython-previews--112196.org.readthedocs.build/

@bedevere-appbedevere-appbot added awaiting review docsDocumentation in the Doc dir skip news labelsNov 17, 2023
@AlexWaygoodAlexWaygood self-requested a reviewNovember 17, 2023 10:23
@AlexWaygoodAlexWaygood changed the titlegh-94309: Fix documentation for deprecated aliasesgh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.SizedNov 17, 2023
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

salty-horse reacted with heart emoji
@AlexWaygoodAlexWaygoodenabled auto-merge (squash)November 17, 2023 12:25
@AlexWaygoodAlexWaygood self-assigned thisNov 17, 2023
@AlexWaygoodAlexWaygood merged commitfb4cddb intopython:mainNov 17, 2023
@miss-islington-app
Copy link

Thanks@salty-horse for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 17, 2023
…ce for typing.Hashable and typing.Sized (pythonGH-112196)(cherry picked from commitfb4cddb)Co-authored-by: Ori Avtalion <ori@avtalion.name>
@bedevere-app
Copy link

GH-112200 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 17, 2023
AlexWaygood pushed a commit that referenced this pull requestNov 17, 2023
…ice for typing.Hashable and typing.Sized (GH-112196) (#112200)gh-94309: "What's new in Python 3.12": improve deprecation notice for typing.Hashable and typing.Sized (GH-112196)(cherry picked from commitfb4cddb)Co-authored-by: Ori Avtalion <ori@avtalion.name>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels
docsDocumentation in the Doc dirskip newstopic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@salty-horse@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp