Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-112186: Improve test casetest_loop_is_closed_resource_warnings#112187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dpr-0
Copy link
Contributor

@dpr-0dpr-0 commentedNov 17, 2023•
edited by bedevere-appbot
Loading

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a semantic change. The old codeallows an exception; the replacementrequires one and will fail if something is improved to avoid it. Do you really want this. If not, I would add a note that it would be OK to prevent the exception and remove the assert.

Minor nit: I think the comment fits better under the assert, after the object 'this' points to.

dpr-0 reacted with thumbs up emoji
@dpr-0
Copy link
ContributorAuthor

Do you really want this.

No. I just currently can not preventRuntimeError while producing this test case scenario.

I would add a note that it would be OK to prevent the exception and remove the assert.

Thanks. It can be removed if there is noRuntimeError occur in the future.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG, but I like to indent the comment.

@gvanrossumgvanrossumenabled auto-merge (squash)November 19, 2023 03:06
@gvanrossumgvanrossum added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsNov 19, 2023
@gvanrossumgvanrossum merged commit18c6929 intopython:mainNov 19, 2023
@miss-islington-app
Copy link

Thanks@dpr-0 for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry,@dpr-0 and@gvanrossum, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 18c692946953e586db432fd06c856531a2b05127 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 19, 2023
…ings` (pythonGH-112187)(cherry picked from commit18c6929)Co-authored-by: DPR <dpr-0xff@pm.me>
@bedevere-app
Copy link

GH-112255 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 19, 2023
dpr-0 added a commit to dpr-0/cpython that referenced this pull requestNov 19, 2023
@bedevere-app
Copy link

GH-112261 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelNov 19, 2023
@dpr-0dpr-0 deleted the Improve-test-case-test_loop_is_closed_resource_warnings branchNovember 19, 2023 09:20
gvanrossum pushed a commit that referenced this pull requestNov 19, 2023
…nings` (GH-112187) (#112255)(cherry picked from commit18c6929)Co-authored-by: DPR <dpr-0xff@pm.me>
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@terryjreedyterryjreedyterryjreedy left review comments

@gvanrossumgvanrossumgvanrossum approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@gvanrossumgvanrossum

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@dpr-0@gvanrossum@terryjreedy@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp