Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-112155: Runtyping.py doctests during tests#112156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 4 commits intopython:mainfromsobolevn:issue-112155
Nov 16, 2023

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedNov 16, 2023
edited by bedevere-appbot
Loading

After this change we can detect some hypothetical problems withdoctests intyping.py.
After my change to some incorrect value doctest fails:

» ./python.exe -m test test_typing   Using random seed: 31719993750:00:00 load avg: 1.44 Run 1 test sequentially0:00:00 load avg: 1.44 [1/1] test_typingtest test_typing failed -- Traceback (most recent call last):  File "/Users/sobolev/Desktop/cpython2/Lib/doctest.py", line 2267, in runTest    raise self.failureException(self.format_failure(new.getvalue()))AssertionError: Failed doctest test for typing.get_protocol_members  File "/Users/sobolev/Desktop/cpython2/Lib/typing.py", line 3398, in get_protocol_members----------------------------------------------------------------------File "/Users/sobolev/Desktop/cpython2/Lib/typing.py", line 3407, in typing.get_protocol_membersFailed example:    get_protocol_members(P)Expected:    frozenset({'a', 'b', 'c'})Got:    frozenset({'a', 'b'})test_typing failed (1 failure)== Tests result: FAILURE ==1 test failed:    test_typingTotal duration: 253 msTotal tests: run=601 failures=1 skipped=1Total test files: run=1/1 failed=1Result: FAILURE

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks!

@AlexWaygoodAlexWaygoodenabled auto-merge (squash)November 16, 2023 15:25
@AlexWaygoodAlexWaygood self-assigned thisNov 16, 2023
@AlexWaygoodAlexWaygood merged commit7680da4 intopython:mainNov 16, 2023
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn and@AlexWaygood, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7680da458398c5a08b9c32785b1eeb7b7c0887e4 3.12

@miss-islington-app
Copy link

Sorry,@sobolevn and@AlexWaygood, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 7680da458398c5a08b9c32785b1eeb7b7c0887e4 3.11

@sobolevn
Copy link
MemberAuthor

Will do manual backports later

@AlexWaygood
Copy link
Member

Will do manual backports later

I just realised that there are no doctests inLib/typing.py on the 3.12 or 3.11 branches, so there's no need :)

I'll just remove the "needs backport" labels.

@AlexWaygoodAlexWaygood removed needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsNov 16, 2023
@AlexWaygood
Copy link
Member

I just realised that there are no doctests inLib/typing.py on the 3.12 or 3.11 branches, so there's no need :)

We nowdo, of course, following the changes made for#112194, so if you're still up for backporting this to 3.12 and 3.11, that would be great :-)

@sobolevn
Copy link
MemberAuthor

Sure!

AlexWaygood reacted with heart emoji

sobolevn added a commit to sobolevn/cpython that referenced this pull requestNov 18, 2023
@bedevere-app
Copy link

GH-112230 is a backport of this pull request to the3.12 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull requestNov 18, 2023
@bedevere-app
Copy link

GH-112231 is a backport of this pull request to the3.11 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

@AlexWaygoodAlexWaygood

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp